Skip to content
This repository was archived by the owner on Mar 27, 2026. It is now read-only.

add OneTrustQuestionComment to oneTrust types#225

Merged
abrantesarthur merged 19 commits intomainfrom
oneTrustTypes
Mar 20, 2025
Merged

add OneTrustQuestionComment to oneTrust types#225
abrantesarthur merged 19 commits intomainfrom
oneTrustTypes

Conversation

@abrantesarthur
Copy link
Copy Markdown
Contributor

@abrantesarthur abrantesarthur commented Mar 20, 2025

Related Issues

Description

  • We need this to support importing assessment question comments from OneTrust. This is part of a minor patch I'm writing to fulfill an Informa request.

@height
Copy link
Copy Markdown

height Bot commented Mar 20, 2025

This pull request has been linked to and will mark 1 task as "Pending Deploy" when merged:


This pull request has also been linked to 1 additional task:

@abrantesarthur abrantesarthur changed the title create oneTrust assessment types add OneTrustQuestionComment to oneTrust types Mar 20, 2025
@abrantesarthur abrantesarthur requested a review from a team March 20, 2025 23:02
Copy link
Copy Markdown
Member

@lvonessen lvonessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 🎉

Comment on lines +34 to +35
CreatedBy: t.string,
CreateDate: t.string,
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This capitalization is different than I've seen on other one trust types. Is there a typo or is one trust just not consistent?

(I noticed when I was about to submit my review that I was also not consistent--my other comment says OneTrust 😂)

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good question. yeah, unfortunately this is correct 😆 That's how OneTrust gives it to us.

export const OneTrustQuestionComments = t.array(OneTrustQuestionComment);

/**
* A list of OneTrust comment manually injected to the question
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: comment -> comments

I'm also not totally sure what you mean by manually injected--is this because the question didn't originally come with these comments when we got it from OneTrust and we're attaching them ourselves? Maybe something like "A list of OneTrust comments related to the question" is clear enough?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good question. It was manually injected by the customer. Basically we can pull assessments directly from OneTrust, or download them from OneTrust into a json file, then push them to Transcend from this file. The customer injected the file with these comments.

@abrantesarthur abrantesarthur merged commit cbc768a into main Mar 20, 2025
10 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants