add OneTrustQuestionComment to oneTrust types#225
Conversation
|
This pull request has been linked to and will mark 1 task as "Pending Deploy" when merged:
This pull request has also been linked to 1 additional task:
|
| CreatedBy: t.string, | ||
| CreateDate: t.string, |
There was a problem hiding this comment.
This capitalization is different than I've seen on other one trust types. Is there a typo or is one trust just not consistent?
(I noticed when I was about to submit my review that I was also not consistent--my other comment says OneTrust 😂)
There was a problem hiding this comment.
good question. yeah, unfortunately this is correct 😆 That's how OneTrust gives it to us.
| export const OneTrustQuestionComments = t.array(OneTrustQuestionComment); | ||
|
|
||
| /** | ||
| * A list of OneTrust comment manually injected to the question |
There was a problem hiding this comment.
nit: comment -> comments
I'm also not totally sure what you mean by manually injected--is this because the question didn't originally come with these comments when we got it from OneTrust and we're attaching them ourselves? Maybe something like "A list of OneTrust comments related to the question" is clear enough?
There was a problem hiding this comment.
Good question. It was manually injected by the customer. Basically we can pull assessments directly from OneTrust, or download them from OneTrust into a json file, then push them to Transcend from this file. The customer injected the file with these comments.
Related Issues
Description