-
Notifications
You must be signed in to change notification settings - Fork 0
add OneTrustQuestionComment to oneTrust types #225
Changes from all commits
947dea4
1949ac0
9995a51
a5239db
84f2da7
96569c2
7d53899
9d0a13e
ae5ece3
fb338b0
ad73103
e62b660
ecf87c4
d4d3fde
006d36a
900b358
1b30d4a
3f4c4b1
c77e782
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -29,13 +29,36 @@ export const OneTrustEnrichedRisks = t.union([ | |
| /** Type override */ | ||
| export type OneTrustEnrichedRisks = t.TypeOf<typeof OneTrustEnrichedRisks>; | ||
|
|
||
| export const OneTrustQuestionComment = t.type({ | ||
| comment: t.string, | ||
| CreatedBy: t.string, | ||
| CreateDate: t.string, | ||
| }); | ||
|
|
||
| /** | ||
| * A OneTrust comment manually injected to the question | ||
| */ | ||
| export type OneTrustQuestionComment = t.TypeOf<typeof OneTrustQuestionComment>; | ||
|
|
||
| export const OneTrustQuestionComments = t.array(OneTrustQuestionComment); | ||
|
|
||
| /** | ||
| * A list of OneTrust comment manually injected to the question | ||
|
Member
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. nit: comment -> comments I'm also not totally sure what you mean by manually injected--is this because the question didn't originally come with these comments when we got it from OneTrust and we're attaching them ourselves? Maybe something like "A list of OneTrust comments related to the question" is clear enough?
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Good question. It was manually injected by the customer. Basically we can pull assessments directly from OneTrust, or download them from OneTrust into a json file, then push them to Transcend from this file. The customer injected the file with these comments. |
||
| */ | ||
| export type OneTrustQuestionComments = t.TypeOf< | ||
| typeof OneTrustQuestionComments | ||
| >; | ||
|
|
||
| /** The default OneTrust Get Assessment question response with enriched risks. */ | ||
| export const OneTrustEnrichedAssessmentQuestion = t.intersection([ | ||
| t.type({ | ||
| ...OneTrustAssessmentQuestion.types[0].props, | ||
| risks: OneTrustEnrichedRisks, | ||
| }), | ||
| t.partial({ ...OneTrustAssessmentQuestion.types[1].props }), | ||
| t.partial({ | ||
| ...OneTrustAssessmentQuestion.types[1].props, | ||
| comments: OneTrustQuestionComments, | ||
| }), | ||
| ]); | ||
|
|
||
| /** Type override */ | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This capitalization is different than I've seen on other one trust types. Is there a typo or is one trust just not consistent?
(I noticed when I was about to submit my review that I was also not consistent--my other comment says OneTrust 😂)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good question. yeah, unfortunately this is correct 😆 That's how OneTrust gives it to us.