Add @types/express-interceptor - #6513
Conversation
This replaces our inline types for the `express-interceptor` package with the `@types/express-interceptor` package from DefinitelyTyped. Additionally this adds a direct dependency on `@types/express`, because we import `express` directly.
|
| npmPreapprovedPackages: | ||
| - '@types/express-interceptor' | ||
|
|
There was a problem hiding this comment.
This is needed, because the package is still too new according to our npmMinimalAgeGate. We can remove it next week.
There was a problem hiding this comment.
we can also pre-approve the exact version right ?
npmPreapprovedPackages:
- '@types/express-interceptor@1.2.0'https://yarnpkg.com/configuration/yarnrc#npmPreapprovedPackages
There was a problem hiding this comment.
I’m not sure, but do we want that anyway? This seems excessive to keep track of. I trust packages from DefinitelyTyped, and they’re locked in the lockfile anyway.
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
qxprakash
left a comment
qxprakash
left a comment
There was a problem hiding this comment.
looks good ! just one nitpick.
2 participants
This replaces our inline types for the
express-interceptorpackage with the@types/express-interceptorpackage from DefinitelyTyped.Additionally this adds a direct dependency on
@types/express, because we importexpressdirectly.