Skip to content

Add @types/express-interceptor #6513

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
remcohaszing wants to merge 2 commits into
base: main
Choose a base branch
from
+16 −12
Open

Add @types/express-interceptor #6513

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
36b2131
Add @types/express-interceptor
remcohaszing Sep 2, 2026
5ccbd29
Merge branch 'main' into types-express-interceptor
qxprakash Sep 3, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .yarnrc.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,9 @@ npmMinimalAgeGate: 1w

npmPublishAccess: public

npmPreapprovedPackages:
- '@types/express-interceptor'

Comment on lines +21 to +23

@remcohaszing remcohaszing Sep 2, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is needed, because the package is still too new according to our npmMinimalAgeGate. We can remove it next week.

@qxprakash qxprakash Sep 3, 2026

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can also pre-approve the exact version right ?

    npmPreapprovedPackages:
      - '@types/express-interceptor@1.2.0'

https://yarnpkg.com/configuration/yarnrc#npmPreapprovedPackages

@remcohaszing remcohaszing Sep 3, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’m not sure, but do we want that anyway? This seems excessive to keep track of. I trust packages from DefinitelyTyped, and they’re locked in the lockfile anyway.

plugins:
- checksum: c43fb18b0cc042871a14ddc76ec78d35b4bc6896ec1d2b75d137cfc6b6b3e2a83fe6cb8b1d2657700b460e81d843b8dc33c5330db1cce2cffe2d91ce0442eb14
path: .yarn/plugins/@yarnpkg/plugin-dedupe.cjs
Expand Down
2 changes: 2 additions & 0 deletions packages/@uppy/companion/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,8 @@
"devDependencies": {
"@types/cookie-parser": "1.4.10",
"@types/cors": "2.8.19",
"@types/express": "^5.0.6",
"@types/express-interceptor": "^1.2.0",
"@types/express-session": "1.19.0",
"@types/http-proxy": "1.17.17",
"@types/jsonwebtoken": "9.0.10",
Expand Down
12 changes: 0 additions & 12 deletions packages/@uppy/companion/src/types/shims.d.ts
View file
Open in desktop

This file was deleted.

11 changes: 11 additions & 0 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6562,6 +6562,15 @@ __metadata:
languageName: node
linkType: hard

"@types/express-interceptor@npm:^1.2.0":
version: 1.2.0
resolution: "@types/express-interceptor@npm:1.2.0"
dependencies:
"@types/express": "npm:*"
checksum: 10/90cad2d8b1968529e2fd019a8468fa576bc20c6f660677df87299f9e1933475ccb82b9a40eb8f5ae4fd71aab745d1d95723d44de2a775af6ddea7d0aea012253
languageName: node
linkType: hard

"@types/express-serve-static-core@npm:*, @types/express-serve-static-core@npm:^5.0.0":
version: 5.1.1
resolution: "@types/express-serve-static-core@npm:5.1.1"
Expand Down Expand Up @@ -7060,6 +7069,8 @@ __metadata:
"@aws-sdk/s3-request-presigner": "npm:3.1047.0"
"@types/cookie-parser": "npm:1.4.10"
"@types/cors": "npm:2.8.19"
"@types/express": "npm:^5.0.6"
"@types/express-interceptor": "npm:^1.2.0"
"@types/express-session": "npm:1.19.0"
"@types/http-proxy": "npm:1.17.17"
"@types/jsonwebtoken": "npm:9.0.10"
Expand Down