Skip to content

Read only columns #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Peder2911 wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Read only columns #31

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0d7d7e9
Fixed deprecated function call
Peder2911 Aug 30, 2019
39e744f
Added readOnlyCols
Peder2911 Aug 30, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions R/htable.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,10 +29,12 @@
htable <- function(outputId, clickId = NULL, readOnly = FALSE,
colHeaders=c("enabled", "disabled", "provided"),
rowNames=c("disabled", "enabled", "provided"),
minRows=0, minCols=0, width=0, height=0){
minRows=0, minCols=0, width=0, height=0,
readOnlyColumns = c(1,2,3)){

rowNames <- match.arg(rowNames)
colHeaders <- match.arg(colHeaders)
readOnlyColumns = jsonlite::toJSON(readOnlyColumns)

tagList(
singleton(tags$head(
Expand All @@ -48,9 +50,10 @@ htable <- function(outputId, clickId = NULL, readOnly = FALSE,
`data-htable-row-names`=rowNames,
`data-click-id`=clickId,
`data-read-only`=readOnly,
`data-read-only-columns`=readOnlyColumns, # ADDED
`data-min-rows`=minRows,
`data-min-cols`=minCols,
`data-width` = as.numeric(width),
`data-height` = as.numeric(height))
)
}
}
12 changes: 6 additions & 6 deletions R/render-htable.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ renderHtable <- function(expr, env = parent.frame(),
warning ("Factors aren't currently supported. Will convert using as.character().")

# Doesn't work with multiple columns at once, so iterate.
#TODO: Optimize
# TODO: Optimize
for (col in factorInd){
data[,col] <- as.character(data[,col])
}
Expand Down Expand Up @@ -63,13 +63,13 @@ renderHtable <- function(expr, env = parent.frame(),

#TODO: support updating of types, colnames, rownames, etc.

shinysession$session$sendCustomMessage("htable-change",
list(id=name,
changes=delta,
cycle=.cycleCount[[shinysession$token]][[name]]))
shinysession$sendCustomMessage("htable-change",
list(id=name,
changes=delta,
cycle=.cycleCount[[shinysession$token]][[name]]))

# Don't return any data, changes have already been sent.
return(list(cycle=.cycleCount[[shinysession$token]][[name]]))
}
}
}
}
Loading