increase stack size on F4 models#6837
Merged
Merged
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (7)
✅ Files skipped from review due to trivial changes (6)
🚧 Files skipped from review as they are similar to previous changes (1)
WalkthroughKernel memory layout constants were updated across multiple embed models (D001, T2B1, T2T1) and an STM32F4 linker script: the kernel main stack size ( Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
| model | device_test | click_test | persistence_test |
|---|---|---|---|
| T2T1 |  test(all)  main(all)  |
 test(all)  main(all)  |
 test(all)  main(all)  |
| T3B1 |  test(all)  main(all)  |
 test(all)  main(all)  |
 test(all)  main(all)  |
| T3T1 |  test(all)  main(all)  |
 test(all)  main(all)  |
 test(all)  main(all)  |
| T3W1 |  test(all)  main(all)  |
 test(all)  main(all)  |
 test(all)  main(all)  |
Latest CI run: 25014717763
TychoVrahe
force-pushed
the
tychovrahe/fix/tt_stack_overflow
branch
from
7f3d5d6 to
53c4f8d
Compare
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@core/embed/models/D001/memory.h`:
- Around line 108-109: AUX2 currently starts at 0x10002000 and overlaps the
kernel main stack; update the definition AUX2_RAM_START in memory.h from
0x10002000 to 0x10002800 (leave AUX2_RAM_SIZE unchanged) so AUX2 begins at the
end of K_MAIN_STACK (K_MAIN_STACK_START + 10 KiB), then regenerate the generated
linker file memory.ld so the symbol AUX2_RAM_START in that file is also
0x10002800.
In `@core/embed/sys/linker/stm32f4/kernel.ld`:
- Line 47: The linker script kernel.ld uses the nonconforming location-counter
syntax `. = +10K;`; update this to the project-standard `. += 10K;` so the stack
allocation line (the location counter expression in
core/embed/sys/linker/stm32f4/kernel.ld) matches other linker scripts
(stm32f4/stm32u5g/stm32u58) and preserves the intended 10K increment for the
stack.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 8777d682-5775-4359-99b4-fa5254082d51
📒 Files selected for processing (7)
core/embed/models/D001/memory.hcore/embed/models/D001/memory.ldcore/embed/models/T2B1/memory.hcore/embed/models/T2B1/memory.ldcore/embed/models/T2T1/memory.hcore/embed/models/T2T1/memory.ldcore/embed/sys/linker/stm32f4/kernel.ld
cepetr
approved these changes
Apr 27, 2026
[no changelog]
TychoVrahe
force-pushed
the
tychovrahe/fix/tt_stack_overflow
branch
from
0eef21e to
b426d72
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes RSOD during booloader update.