-
-
Notifications
You must be signed in to change notification settings - Fork 302
Feat: protocol-thp encode/decode #19073
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
c6926e6
to
7199712
Compare
✅ Previously successful run of [Test] PR Suite Web e2e tests workflow has been found. |
7199712
to
0c4beec
Compare
✅ Previously successful run of [Test] PR Suite Web e2e tests workflow has been found. |
1 similar comment
✅ Previously successful run of [Test] PR Suite Web e2e tests workflow has been found. |
✅ Previously successful run of [Test] PR Suite Desktop e2e tests workflow has been found. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
✅ Previously successful run of [Test] PR Suite Desktop e2e tests workflow has been found. |
✅ Previously successful run of [Test] PR Suite Web e2e tests workflow has been found. |
Lastminute change as promised, |
/rebase |
Start rebasing: https://github.com/trezor/trezor-suite/actions/runs/15205527129 |
- only one message exchange is supported ThpCreateChannelRequest > ThpCreateChannelResponse - without cryptography module. will be added in the next commit
7f5111d
to
98d210d
Compare
✅ Previously successful run of [Test] PR Suite Web e2e tests workflow has been found. |
✅ Previously successful run of [Test] PR Suite Desktop e2e tests workflow has been found. |
Description
add THP encoding/decoding logic
ThpCreateChannelRequest
>ThpCreateChannelResponse
ThpAck
andThpError
🔍🖥️ Suite web test results: View in Currents
🔍🖥️ Suite desktop test results: View in Currents