chore(redux-utils): remove unused notImplementedOriginalReduxThunk factory - #27835
Merged
Conversation
…ctory (cherry picked from commit 997dc98e09522483b6bf6a3abcf811b57c2f5346)
This was referenced May 17, 2026
Merged
mroz22
marked this pull request as ready for review
May 17, 2026 12:49
Contributor
There was a problem hiding this comment.
Pull request overview
Removes an unused Redux utility factory from @suite-common/redux-utils, reducing dead code in a shared internal package.
Changes:
- Deleted
notImplementedOriginalReduxThunkfromnotImplemented.ts. - Verified no remaining references to the removed export in the repository.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Lemonexe
approved these changes
May 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes the unused
notImplementedOriginalReduxThunkfactory from@suite-common/redux-utils. Confirmed no callers across the monorepo.Split out from the staging dead-code PR #27551 (suite-common/* batch).
Related PRs
Sibling PRs in this batch (each removes one piece of dead code from
suite-common/*):Parent staging PR: #27551
Test plan
🤖 LLM Test Recommendations
Summary: The changed file
suite-common/redux-utils/src/notImplemented.tsis a low-level utility in the redux-utils package that likely provides a helper for marking unimplemented functionality (e.g., throwing errors for abstract methods). No tests statically map to this file, and none of the LLM-analyzed E2E tests referencenotImplementedorredux-utilsin their source hints. This is a foundational utility whose changes would most likely manifest as build-time or unit-test failures rather than E2E behavioral regressions. No E2E tests are recommended; unit tests and type checks should provide sufficient coverage.Changed files (1)
suite-common/redux-utils/src/notImplemented.tsNo test recommendations found.
suite-common/redux-utils/src/notImplemented.tsUpdated: 2026-05-17T06:43:25.218Z
🔍 Currents Test Results
🔍 Suite desktop test results: View in Currents
🔍 Suite web test results: View in Currents
🔍 Suite native android test results: View in Currents
🔒 Quarantined E2E Tests
Trezor Suite (web) — 4 test(s)
Updated: 2026-05-17T06:48:19.950Z • 4 test(s) total
Trezor Suite (desktop) — 2 test(s)
Updated: 2026-05-17T06:47:22.461Z • 2 test(s) total
🌐 Preview deployments
🌐 Suite Web preview: https://dev.suite.sldev.cz/suite-web/mroz22/dead-code-redux-utils/web/