Skip to content

chore(redux-utils): remove unused notImplementedOriginalReduxThunk factory - #27835

Merged
mroz22 merged 1 commit into
developfrom
mroz22/dead-code-redux-utils
May 21, 2026
Merged

chore(redux-utils): remove unused notImplementedOriginalReduxThunk factory#27835
mroz22 merged 1 commit into
developfrom
mroz22/dead-code-redux-utils

Conversation

@mroz22

@mroz22 mroz22 commented May 17, 2026

Copy link
Copy Markdown
Contributor

Summary

Removes the unused notImplementedOriginalReduxThunk factory from @suite-common/redux-utils. Confirmed no callers across the monorepo.

Split out from the staging dead-code PR #27551 (suite-common/* batch).

Related PRs

Sibling PRs in this batch (each removes one piece of dead code from suite-common/*):

Parent staging PR: #27551

Test plan

  • CI typecheck and tests pass

🤖 LLM Test Recommendations

Summary: The changed file suite-common/redux-utils/src/notImplemented.ts is a low-level utility in the redux-utils package that likely provides a helper for marking unimplemented functionality (e.g., throwing errors for abstract methods). No tests statically map to this file, and none of the LLM-analyzed E2E tests reference notImplemented or redux-utils in their source hints. This is a foundational utility whose changes would most likely manifest as build-time or unit-test failures rather than E2E behavioral regressions. No E2E tests are recommended; unit tests and type checks should provide sufficient coverage.

Changed files (1)
  • suite-common/redux-utils/src/notImplemented.ts

No test recommendations found.

⚠️ Changes with no test coverage (1)

  • suite-common/redux-utils/src/notImplemented.ts

Updated: 2026-05-17T06:43:25.218Z

🔍 Currents Test Results

🔍 Suite desktop test results: View in Currents

🔍 Suite web test results: View in Currents

🔍 Suite native android test results: View in Currents

🔒 Quarantined E2E Tests

Trezor Suite (web) — 4 test(s)
Test Type
Quarantine test: "Onboarding - create wallet,Success (basic)" 🙋 manual
Quarantine test: "Database migration,Db migration between: release/22.5/web => develop/web" 🙋 manual
Quarantine test: "Multiple sessions,Session overtaken by another" 🙋 manual
Quarantine test: "Recovery T2T1 - dry run,Recovery after partial recovery" 🙋 manual

Updated: 2026-05-17T06:48:19.950Z • 4 test(s) total

Trezor Suite (desktop) — 2 test(s)
Test Type
Onboarding - create wallet > Success (basic) 🤖 auto
Quarantine test: "Multiple sessions,Session overtaken by another" 🙋 manual

Updated: 2026-05-17T06:47:22.461Z • 2 test(s) total

🌐 Preview deployments

🌐 Suite Web preview: https://dev.suite.sldev.cz/suite-web/mroz22/dead-code-redux-utils/web/

…ctory

(cherry picked from commit 997dc98e09522483b6bf6a3abcf811b57c2f5346)

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes an unused Redux utility factory from @suite-common/redux-utils, reducing dead code in a shared internal package.

Changes:

  • Deleted notImplementedOriginalReduxThunk from notImplemented.ts.
  • Verified no remaining references to the removed export in the repository.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@mroz22
mroz22 requested a review from Lemonexe May 21, 2026 15:41
@mroz22
mroz22 merged commit cef3ce0 into develop May 21, 2026
61 of 65 checks passed
@mroz22
mroz22 deleted the mroz22/dead-code-redux-utils branch May 21, 2026 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

code Code improvements no-project This label is used to specify that PR doesn't need to be added to a project

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants