chore(wallet-config): remove unused hasNetworkSettlementLayer and isProdStakingNetworkSymbol - #27841
Merged
Merged
Conversation
…rodStakingNetworkSymbol (cherry picked from commit 6616e58430d7f2e2b5249d9df1a6efb856ab0bff)
This was referenced May 17, 2026
mroz22
marked this pull request as ready for review
May 17, 2026 11:46
Contributor
There was a problem hiding this comment.
Pull request overview
Removes two unused wallet-config utility exports from the shared @suite-common/wallet-config package, reducing dead code without changing the underlying network configuration data.
Changes:
- Removed
hasNetworkSettlementLayer. - Removed
isProdStakingNetworkSymbol. - Cleaned up now-unused imports from
utils.ts.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Lemonexe
approved these changes
May 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes the unused exports
hasNetworkSettlementLayerandisProdStakingNetworkSymbolfrom@suite-common/wallet-config. Confirmed no callers across the monorepo.Split out from the staging dead-code PR #27551 (suite-common/* batch).
Related PRs
Sibling PRs in this batch (each removes one piece of dead code from
suite-common/*):Parent staging PR: #27551
Test plan
🤖 LLM Test Recommendations
Summary: The changed file
suite-common/wallet-config/src/utils.tsis a broad shared utility that maps to 121 tests, indicating it is a foundational/global dependency. Without seeing the specific diff, we cannot determine which particular network configurations, backend utilities, or wallet config behaviors were altered. None of the 121 tests in the LLM analysis show direct, specific reliance on particular logic withinwallet-config/src/utils.tsthat would make them clearly more affected than others — they all transitively import it through network configuration, coin settings, or discovery flows. Given the extremely broad mapping and lack of specific evidence that any single test's code path is more directly affected, the recommended strategy is to rely on unit tests for this utility file rather than running a large set of E2E tests. If the change is known to affect specific network resolution, coin enablement, or backend selection logic, targeted tests likecoins.test.ts,coins-custom-backend.test.ts, ordiscovery.test.tswould be the most relevant candidates, but without that specificity, no E2E tests can be confidently prioritized above others.Changed files (1)
suite-common/wallet-config/src/utils.tsNo test recommendations found.
Updated: 2026-05-17T06:44:31.926Z
🔍 Currents Test Results
🔍 Suite desktop test results: View in Currents
🔍 Suite web test results: View in Currents
🔍 Suite native android test results: View in Currents
🔒 Quarantined E2E Tests
Trezor Suite (web) — 4 test(s)
Updated: 2026-05-17T06:48:36.759Z • 4 test(s) total
Trezor Suite (desktop) — 2 test(s)
Updated: 2026-05-17T06:47:42.804Z • 2 test(s) total
🌐 Preview deployments
🌐 Suite Web preview: https://dev.suite.sldev.cz/suite-web/mroz22/dead-code-wallet-config/web/