Skip to content

chore(wallet-config): remove unused hasNetworkSettlementLayer and isProdStakingNetworkSymbol - #27841

Merged
mroz22 merged 1 commit into
developfrom
mroz22/dead-code-wallet-config
May 21, 2026
Merged

chore(wallet-config): remove unused hasNetworkSettlementLayer and isProdStakingNetworkSymbol#27841
mroz22 merged 1 commit into
developfrom
mroz22/dead-code-wallet-config

Conversation

@mroz22

@mroz22 mroz22 commented May 17, 2026

Copy link
Copy Markdown
Contributor

Summary

Removes the unused exports hasNetworkSettlementLayer and isProdStakingNetworkSymbol from @suite-common/wallet-config. Confirmed no callers across the monorepo.

Split out from the staging dead-code PR #27551 (suite-common/* batch).

Related PRs

Sibling PRs in this batch (each removes one piece of dead code from suite-common/*):

Parent staging PR: #27551

Test plan

  • CI typecheck and tests pass

🤖 LLM Test Recommendations

Summary: The changed file suite-common/wallet-config/src/utils.ts is a broad shared utility that maps to 121 tests, indicating it is a foundational/global dependency. Without seeing the specific diff, we cannot determine which particular network configurations, backend utilities, or wallet config behaviors were altered. None of the 121 tests in the LLM analysis show direct, specific reliance on particular logic within wallet-config/src/utils.ts that would make them clearly more affected than others — they all transitively import it through network configuration, coin settings, or discovery flows. Given the extremely broad mapping and lack of specific evidence that any single test's code path is more directly affected, the recommended strategy is to rely on unit tests for this utility file rather than running a large set of E2E tests. If the change is known to affect specific network resolution, coin enablement, or backend selection logic, targeted tests like coins.test.ts, coins-custom-backend.test.ts, or discovery.test.ts would be the most relevant candidates, but without that specificity, no E2E tests can be confidently prioritized above others.

Changed files (1)
  • suite-common/wallet-config/src/utils.ts

No test recommendations found.

Updated: 2026-05-17T06:44:31.926Z

🔍 Currents Test Results

🔍 Suite desktop test results: View in Currents

🔍 Suite web test results: View in Currents

🔍 Suite native android test results: View in Currents

🔒 Quarantined E2E Tests

Trezor Suite (web) — 4 test(s)
Test Type
Quarantine test: "Onboarding - create wallet,Success (basic)" 🙋 manual
Quarantine test: "Database migration,Db migration between: release/22.5/web => develop/web" 🙋 manual
Quarantine test: "Multiple sessions,Session overtaken by another" 🙋 manual
Quarantine test: "Recovery T2T1 - dry run,Recovery after partial recovery" 🙋 manual

Updated: 2026-05-17T06:48:36.759Z • 4 test(s) total

Trezor Suite (desktop) — 2 test(s)
Test Type
Onboarding - create wallet > Success (basic) 🤖 auto
Quarantine test: "Multiple sessions,Session overtaken by another" 🙋 manual

Updated: 2026-05-17T06:47:42.804Z • 2 test(s) total

🌐 Preview deployments

🌐 Suite Web preview: https://dev.suite.sldev.cz/suite-web/mroz22/dead-code-wallet-config/web/

…rodStakingNetworkSymbol

(cherry picked from commit 6616e58430d7f2e2b5249d9df1a6efb856ab0bff)

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes two unused wallet-config utility exports from the shared @suite-common/wallet-config package, reducing dead code without changing the underlying network configuration data.

Changes:

  • Removed hasNetworkSettlementLayer.
  • Removed isProdStakingNetworkSymbol.
  • Cleaned up now-unused imports from utils.ts.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@mroz22
mroz22 requested review from Lemonexe and tomasklim May 17, 2026 12:31
@mroz22
mroz22 merged commit bb417b3 into develop May 21, 2026
57 of 59 checks passed
@mroz22
mroz22 deleted the mroz22/dead-code-wallet-config branch May 21, 2026 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

code Code improvements no-project This label is used to specify that PR doesn't need to be added to a project

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants