Skip to content

Fix for name/handling of the group auth secret name helper #361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nineinchnick merged 3 commits into from
Jul 11, 2025
Merged

Fix for name/handling of the group auth secret name helper #361

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
80ec9f0
fixes val name to match the rest
vctrstrm Jun 23, 2025
2aeb1a9
fixes .Values ref to groups secret name
vctrstrm Jun 27, 2025
29c8dcf
re-rendered README.md
vctrstrm Jun 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion charts/trino/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -460,7 +460,7 @@ Fast distributed SQL query engine for big data analytics that helps you explore
```
Set the name of a secret containing this file in the group.db key
```yaml
groupAuthSecret: "trino-group-authentication"
groupsAuthSecret: "trino-groups-authentication"
```
* `serviceAccount.create` - bool, default: `false`

Expand Down
4 changes: 2 additions & 2 deletions charts/trino/templates/_helpers.tpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,8 +144,8 @@ Create the secret name for the file-based authentication's password file
Create the secret name for the group-provider file
*/}}
{{- define "trino.groupsSecretName" -}}
{{- if and .Values.auth .Values.auth.groupAuthSecret }}
{{- .Values.auth.groupAuthSecret | trunc 63 | trimSuffix "-" }}
{{- if and .Values.auth .Values.auth.groupsAuthSecret }}
{{- .Values.auth.groupsAuthSecret }}
{{- else }}
{{- $name := default .Chart.Name .Values.nameOverride }}
{{- if hasPrefix .Release.Name $name }}
Expand Down
2 changes: 1 addition & 1 deletion charts/trino/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -513,7 +513,7 @@ auth: {}
# ```
# Set the name of a secret containing this file in the group.db key
# ```yaml
# groupAuthSecret: "trino-group-authentication"
# groupsAuthSecret: "trino-groups-authentication"
# ```

serviceAccount:
Expand Down