-
Notifications
You must be signed in to change notification settings - Fork 213
Fix for name/handling of the group auth secret name helper #361
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla |
|
signed cla submitted 👍 |
|
Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla |
|
Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla |
|
@nineinchnick it seems CLA approval process is a bit stuck. Any idea if there's someone we could tap on the shoulder to help approve it? Would love to contribute more to the project :) |
|
cla list updated (trying to see if this will trigger re-check) |
|
@cla-bot check |
|
The cla-bot has been summoned, and re-checked this pull request! |
Template for group auth secret is misspelled as .Values.auth.groupAuthSecret when it should be .Values.auth.groupsAuthSecret (the value name used in all other templates)
Additionally, since the the value of ".Values.auth.groupsAuthSecret" is meant to be a secret name, I removed truncation/trimming as the name should be taken verbatim
Without this fix, the workaround is to declare duplicate env vars for both: