Skip to content

Conversation

@vctrstrm
Copy link
Member

@vctrstrm vctrstrm commented Jun 23, 2025

Template for group auth secret is misspelled as .Values.auth.groupAuthSecret when it should be .Values.auth.groupsAuthSecret (the value name used in all other templates)

Additionally, since the the value of ".Values.auth.groupsAuthSecret" is meant to be a secret name, I removed truncation/trimming as the name should be taken verbatim

Without this fix, the workaround is to declare duplicate env vars for both:

auth:
  # [BUG WORKAROUND] - template references secret with two different names, hence duplication
  groupAuthSecret: trino-group-auth
  groupsAuthSecret: trino-group-auth
  passwordAuthSecret: trino-password-auth

@cla-bot
Copy link

cla-bot bot commented Jun 23, 2025

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

@vctrstrm
Copy link
Member Author

signed cla submitted 👍

@cla-bot
Copy link

cla-bot bot commented Jun 27, 2025

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

@cla-bot
Copy link

cla-bot bot commented Jun 27, 2025

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

@vctrstrm vctrstrm requested a review from nineinchnick June 27, 2025 15:40
@vctrstrm
Copy link
Member Author

vctrstrm commented Jul 4, 2025

@nineinchnick it seems CLA approval process is a bit stuck. Any idea if there's someone we could tap on the shoulder to help approve it? Would love to contribute more to the project :)

@nineinchnick
Copy link
Member

@martint handles the CLA every few weeks. The file was updated 3 weeks ago, so I'd expect another batch to be done soon.

@vctrstrm
Copy link
Member Author

cla list updated (trying to see if this will trigger re-check)

@nineinchnick
Copy link
Member

@cla-bot check

@cla-bot cla-bot bot added the cla-signed label Jul 11, 2025
@cla-bot
Copy link

cla-bot bot commented Jul 11, 2025

The cla-bot has been summoned, and re-checked this pull request!

@nineinchnick nineinchnick added the bug Something isn't working label Jul 11, 2025
@nineinchnick nineinchnick merged commit 969be80 into trinodb:main Jul 11, 2025
11 checks passed
@vctrstrm vctrstrm deleted the bugfix/template-auth-vals branch July 11, 2025 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working cla-signed

Development

Successfully merging this pull request may close these issues.

2 participants