Skip to content

Elastic search plugin support for pushdown TopN and Aggregation #16919

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Elastic search plugin support for pushdown TopN and Aggregation #16919

wants to merge 1 commit into from

Conversation

murthy-chelankuri
Copy link
Member

@murthy-chelankuri murthy-chelankuri commented Apr 6, 2023 •
edited
Loading

Description

Additional context and related issues

This PR provides the support pushing down TopN and Aggregation function to elasticsearch.

( ) This is not user-visible or docs only and no release notes are required.
( x) Release notes are required, please propose a release note for me.
( ) Release notes are required, with the following suggested text:

# Fixes

@cla-bot cla-bot bot added the cla-signed label Apr 6, 2023
@murthy-chelankuri murthy-chelankuri mentioned this pull request Apr 6, 2023
Closed
@murthy-chelankuri murthy-chelankuri changed the title Es pushdown topn aggregation1 Elastic search plugin support for pushdown TopN and Aggregation Apr 6, 2023
@murthy-chelankuri murthy-chelankuri changed the title Elastic search plugin support for pushdown TopN and Aggregation WP: Elastic search plugin support for pushdown TopN and Aggregation Apr 6, 2023
@murthy-chelankuri murthy-chelankuri changed the title WP: Elastic search plugin support for pushdown TopN and Aggregation Elastic search plugin support for pushdown TopN and Aggregation Apr 15, 2023
@kokosing kokosing requested a review from hashhar April 16, 2023 06:44
@murthy-chelankuri murthy-chelankuri force-pushed the es-pushdown-topn-aggregation1 branch 2 times, most recently from da648d1 to 4f39507 Compare May 22, 2023 14:46
@cploonker
Copy link

cploonker commented Jul 10, 2023 •
edited
Loading

Following for updates. Elastic is a widely used data store and it has very poor sql support.

@github-actions github-actions bot added release-notes docs jdbc Relates to Trino JDBC driver tests:hive labels Sep 8, 2023
@murthy-chelankuri murthy-chelankuri force-pushed the es-pushdown-topn-aggregation1 branch 4 times, most recently from 7cc30df to eeadd1f Compare September 18, 2023 19:26
@murthy-chelankuri
Copy link
Member Author

@hashhar @kokosing , Can you please review this merge request

@murthy-chelankuri murthy-chelankuri force-pushed the es-pushdown-topn-aggregation1 branch from d6085f6 to f8c1a67 Compare September 25, 2023 21:11
@github-actions github-actions bot added hudi Hudi connector iceberg Iceberg connector delta-lake Delta Lake connector hive Hive connector bigquery BigQuery connector mongodb MongoDB connector labels Sep 25, 2023
@murthy-chelankuri murthy-chelankuri force-pushed the es-pushdown-topn-aggregation1 branch from f8c1a67 to eeadd1f Compare September 25, 2023 21:24
@murthy-chelankuri murthy-chelankuri force-pushed the es-pushdown-topn-aggregation1 branch from eeadd1f to e1dc146 Compare September 25, 2023 21:37
@murthy-chelankuri
Copy link
Member Author

@mosabua now the tests are running without any failures can you help me to get the changes at the earliest.

@mosabua
Copy link
Member

mosabua commented Feb 21, 2024

Can you please squash the commits and ensure the build actually passes. Currently CI is still failing.

@murthy-chelankuri murthy-chelankuri force-pushed the es-pushdown-topn-aggregation1 branch from a4e5ae3 to 8370b83 Compare February 21, 2024 06:31
@murthy-chelankuri
Copy link
Member Author

@mosabua Thank you for the information. I have squashed the commits and the pipeline has passed all checks.

@mosabua
Copy link
Member

mosabua commented Feb 21, 2024

Can you change the commit message to

Add support for TopN and aggregation pushdown

@murthy-chelankuri

I will see if @wendigo @ebyhr or others are available for review help.

@murthy-chelankuri murthy-chelankuri force-pushed the es-pushdown-topn-aggregation1 branch from 8370b83 to c6e1df2 Compare February 22, 2024 05:55
@murthy-chelankuri
Copy link
Member Author

Can you change the commit message to

Add support for TopN and aggregation pushdown

@murthy-chelankuri

I will see if @wendigo @ebyhr or others are available for review help.

Changed the commit message as per your suggestion

@murthy-chelankuri
Copy link
Member Author

@mosabua can you help to prioritize the code review for this PR before we lose traction?

@murthy-chelankuri murthy-chelankuri force-pushed the es-pushdown-topn-aggregation1 branch from c6e1df2 to 51e52b7 Compare March 2, 2024 22:53
@jbackofe
Copy link

jbackofe commented Mar 6, 2024

Looking forward to this feature!

@github-actions GitHub Actions
Copy link

This pull request has gone a while without any activity. Tagging the Trino developer relations team: @bitsondatadev @colebow @mosabua

@github-actions github-actions bot added the stale label Mar 28, 2024
@wendigo wendigo requested a review from ebyhr March 28, 2024 17:46
@ebyhr ebyhr requested review from martint and removed request for ebyhr March 29, 2024 00:48
@github-actions github-actions bot removed the stale label Mar 29, 2024
@murthy-chelankuri murthy-chelankuri force-pushed the es-pushdown-topn-aggregation1 branch from 51e52b7 to dcdd765 Compare May 6, 2024 22:59
@github-actions GitHub Actions
Copy link

This pull request has gone a while without any activity. Tagging the Trino developer relations team: @bitsondatadev @colebow @mosabua

@github-actions github-actions bot added the stale label May 28, 2024
@github-actions GitHub Actions
Copy link

Closing this pull request, as it has been stale for six weeks. Feel free to re-open at any time.

@github-actions github-actions bot closed this Jun 18, 2024
@murthy-chelankuri
Copy link
Member Author

I have resolved the merge conflicts, and now everything looks good. All the tests have passed successfully.

@murthy-chelankuri
Copy link
Member Author

@bitsondatadev @colebow @mosabua is there a way can we open is merge request instead of creaing new one ?

@mosabua
Copy link
Member

mosabua commented Aug 22, 2024

You should be able to reopen the PR. If not just close it and create a new one and link to this one for completeness of info

@mosabua mosabua added stale-ignore Use this label on PRs that should be ignored by the stale bot so they are not flagged or closed. and removed stale labels Aug 22, 2024
@murthy-chelankuri murthy-chelankuri mentioned this pull request Aug 23, 2024
Open
@murthy-chelankuri
Copy link
Member Author

Thanks @mosabua opened new PR (#23118) as i am not able to reopen this PR fro some reason.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kokosing kokosing Awaiting requested review from kokosing

@hashhar hashhar Awaiting requested review from hashhar

@martint martint Awaiting requested review from martint

Assignees
No one assigned
Labels
bigquery BigQuery connector cla-signed delta-lake Delta Lake connector docs hive Hive connector hudi Hudi connector iceberg Iceberg connector jdbc Relates to Trino JDBC driver mongodb MongoDB connector release-notes stale-ignore Use this label on PRs that should be ignored by the stale bot so they are not flagged or closed.
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@murthy-chelankuri @cploonker @mosabua @wendigo @jbackofe @findepi