Add support for TopN and aggregation pushdown in Elasticsearch

[murthy-chelankuri]

Description

This pull request adds support for pushing down TopN and Aggregation to Elasticsearch.

Additional context and related issues

Opening a new merge request because the previous one was automatically closed for being stale, and we couldn't reopen the stale pull request.

#16919

Release notes

( ) This is not user-visible or is docs only, and no release notes are required.
(x) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text:

# Fixes
* Support for order by pushdown in elasticsearch connector #12381 
* Elasticsearch connector aggregation push down support #7026 
* Elasticsearch connector TopN pushdown #4803 

[cla-bot]

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Murthy Chelankuri.
This is most likely caused by a git client misconfiguration; please make sure to:

1. check if your git client is configured with an email to sign commits git config --list | grep email
2. If not, set it up using git config --global user.email email@example.com
3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

[cla-bot]

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: Murthy Chelankuri.
This is most likely caused by a git client misconfiguration; please make sure to:

1. check if your git client is configured with an email to sign commits git config --list | grep email
2. If not, set it up using git config --global user.email email@example.com
3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

[murthy-chelankuri]

@martint @kokosing @hashhar Can you please review this MR at the earliest possible.

[Praveen2112]

Can we split the TopN and aggregation pushdown as a separate commit, this would make the reviews a bit easier

[Praveen2112]

It is always a bit recommended to make the object TopN immutable instead of changing its state here

[murthy-chelankuri]

Thanks @Praveen2112 for the feed back. removed this method and made TopN as immutable.

[Praveen2112]

Can we revert back the indentations ?

[murthy-chelankuri]

Thanks @Praveen2112 for the feedback reverted the indentations.

[Praveen2112]

Can we revert the indentations ?

[murthy-chelankuri]

I am not see any issue with indentation on my editor. Just compared with the previous version i don't see any change in the indentation. Can you please check once ?

[Praveen2112]

Instead of maintaining TopN which maintains limit as well - Can we have an Optional<List<SortOrder>> if the list is present we could consider it as TopN else Limit - But we need to handle what if TopN -> Limit and otherway around

[murthy-chelankuri]

@Praveen2112 , can we keep the topN instead of splitting two arguments Optional<List> and limit? But if that is what we need to do, we can look into changing accordingly.

[github-actions]

This pull request has gone a while without any activity. Tagging the Trino developer relations team: @bitsondatadev @colebow @mosabua

[github-actions]

Closing this pull request, as it has been stale for six weeks. Feel free to re-open at any time.

[github-actions]

This pull request has gone a while without any activity. Tagging for triage help: @mosabua

[mosabua]

Added stale-ignore labels since I think @murthy-chelankuri is wanting to continue work on this .. do you know what your next steps are @murthy-chelankuri or do you need help from reviewers?

[mosabua]

You need to rebase this PR @murthy-chelankuri to proceed .. it is currently not reviewable

[cocobeach1911]

Thank you @murthy-chelankuri for building this!

Any more updates on this?

[github-actions]

This pull request has gone a while without any activity. Ask for help on #core-dev on Trino slack.

[github-actions]

Closing this pull request, as it has been stale for six weeks. Feel free to re-open at any time.