Remove setting metastore SerDe name #23076
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebyhr
reviewed
Aug 21, 2024
jinyangli34
force-pushed
the
jinyang-remove_set_serde_name
branch
from
7dcb3b1 to
d7244aa
Compare
ebyhr
reviewed
Aug 27, 2024
| { | ||
| SerDeInfo serdeInfo = new SerDeInfo(); | ||
| serdeInfo.setName(tableName); |
There was a problem hiding this comment.
name isn't an optional field at https://github.com/apache/hive/blob/04bb92ae6174d2953f42801593b1b709bcf1154c/standalone-metastore/metastore-common/src/main/thrift/hive_metastore.thrift#L443. Is this change really safe?
There was a problem hiding this comment.
I find no where using this field. Spark doesn't set name either (code)
ebyhr
added
stale-ignore
|
👋 Gentle reminder to continue where you left off @jinyangli34 and @ebyhr ... |
ebyhr
removed
the
stale-ignore
|
This pull request has gone a while without any activity. Ask for help on #core-dev on Trino slack. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Avoid setting tableName as serde Name in HMS
Fixes #23075
Release notes
( ) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text: