[18.0][MIG] product_packaging_level: Migration to 18.0 by trisdoan · Pull Request #2 · trisdoan/product-attribute

trisdoan · 2024-11-29T04:06:31Z

Changes in 18.0

get became private since here
_lang_get_xxx were merged into one api _get_data which is simpler and easy to extend since here
Odoo 17.0+: product_id is required on model product_packaging since here
As consequences,
- no need default value in _compute_qty_per_level
- Some little changes on test setup
  - test packagings are assigned with a same product

nguyenminhchien

You should start from this PR: OCA#1662

nguyenminhchien · 2024-12-03T08:09:59Z

product_packaging_level/views/product_packaging_view.xml

+            <field name="package_type_id" position="after">
+                <field name="qty_per_level" />
+                <field name="packaging_level_id" />
+                <field name="barcode_required_for_gtin" invisible="1" />


Suggested change

<field name="barcode_required_for_gtin" invisible="1" />

<field name="barcode_required_for_gtin" column_invisible="1" />

Hi anh, I decided to remove it as:

Missing fields used in domains and other attributes are added to the view as invisible automatically

nguyenminhchien · 2024-12-03T08:10:24Z

product_packaging_level/views/product_packaging_view.xml

+                <attribute name="required">barcode_required_for_gtin</attribute>
+            </xpath>
+            <field name="name" position="attributes">
+                <attribute name="invisible">1</attribute>


Suggested change

<attribute name="invisible">1</attribute>

<attribute name="column_invisible">1</attribute>

nguyenminhchien · 2024-12-03T08:15:14Z

product_packaging_level/models/product_packaging.py

+            ]
+            if len(set(packaging_level_ids)) != len(packaging_level_ids):
+                raise ValidationError(
+                    _(


Suggested change

_(

self.env._(

nguyenminhchien · 2024-12-03T08:15:35Z

product_packaging_level/models/product_packaging_level.py

+            activated_packages = self.env.user.has_group("stock.group_tracking_lot")
+            if packaging.name_policy == "by_package_type" and not activated_packages:
+                raise ValidationError(
+                    _(


Suggested change

_(

self.env._(

nguyenminhchien · 2024-12-03T08:15:49Z

product_packaging_level/models/product_packaging_level.py

+        msg = False
+        default_count = self.search_count([("is_default", "=", True)])
+        if default_count == 0:
+            msg = _('There must be one product packaging level set as "Is Default".')


Suggested change

msg = _('There must be one product packaging level set as "Is Default".')

msg = self.env._('There must be one product packaging level set as "Is Default".')

nguyenminhchien · 2024-12-03T08:15:58Z

product_packaging_level/models/product_packaging_level.py

+        if default_count == 0:
+            msg = _('There must be one product packaging level set as "Is Default".')
+        elif default_count > 1:
+            msg = _('Only one product packaging level can be set as "Is Default".')


Suggested change

msg = _('Only one product packaging level can be set as "Is Default".')

msg = self.env._('Only one product packaging level can be set as "Is Default".')

nguyenminhchien · 2024-12-03T08:19:21Z

You should start from this PR: OCA#1662

You could also review this PR

nguyenminhchien · 2024-12-03T08:29:12Z

This commit 18b6d8a breaks the user-define rule for naming of Packaging: User cannot input name

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: product-attribute-16.0/product-attribute-16.0-product_packaging_level Translate-URL: https://translation.odoo-community.org/projects/product-attribute-16-0/product-attribute-16-0-product_packaging_level/

Currently translated at 100.0% (25 of 25 strings) Translation: product-attribute-16.0/product-attribute-16.0-product_packaging_level Translate-URL: https://translation.odoo-community.org/projects/product-attribute-16-0/product-attribute-16-0-product_packaging_level/es/

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: product-attribute-16.0/product-attribute-16.0-product_packaging_level Translate-URL: https://translation.odoo-community.org/projects/product-attribute-16-0/product-attribute-16-0-product_packaging_level/

Currently translated at 100.0% (32 of 32 strings) Translation: product-attribute-16.0/product-attribute-16.0-product_packaging_level Translate-URL: https://translation.odoo-community.org/projects/product-attribute-16-0/product-attribute-16-0-product_packaging_level/es/

Currently translated at 71.8% (23 of 32 strings) Translation: product-attribute-16.0/product-attribute-16.0-product_packaging_level Translate-URL: https://translation.odoo-community.org/projects/product-attribute-16-0/product-attribute-16-0-product_packaging_level/it/

Currently translated at 100.0% (32 of 32 strings) Translation: product-attribute-16.0/product-attribute-16.0-product_packaging_level Translate-URL: https://translation.odoo-community.org/projects/product-attribute-16-0/product-attribute-16-0-product_packaging_level/it/

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: product-attribute-16.0/product-attribute-16.0-product_packaging_level Translate-URL: https://translation.odoo-community.org/projects/product-attribute-16-0/product-attribute-16-0-product_packaging_level/

Currently translated at 100.0% (32 of 32 strings) Translation: product-attribute-16.0/product-attribute-16.0-product_packaging_level Translate-URL: https://translation.odoo-community.org/projects/product-attribute-16-0/product-attribute-16-0-product_packaging_level/es/

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: product-attribute-16.0/product-attribute-16.0-product_packaging_level Translate-URL: https://translation.odoo-community.org/projects/product-attribute-16-0/product-attribute-16-0-product_packaging_level/

Currently translated at 100.0% (34 of 34 strings) Translation: product-attribute-16.0/product-attribute-16.0-product_packaging_level Translate-URL: https://translation.odoo-community.org/projects/product-attribute-16-0/product-attribute-16-0-product_packaging_level/es/

Currently translated at 100.0% (34 of 34 strings) Translation: product-attribute-16.0/product-attribute-16.0-product_packaging_level Translate-URL: https://translation.odoo-community.org/projects/product-attribute-16-0/product-attribute-16-0-product_packaging_level/it/

…licy

trisdoan · 2024-12-05T08:15:13Z

This commit 18b6d8a breaks the user-define rule for naming of Packaging: User cannot input name

Hi anh, indeed, it blocks user to input name even with user_define policy
I created an extra commit (easily to pick to former versions), dont you agree?

thienvh332 · 2024-12-12T07:10:27Z

product_packaging_level/models/product_packaging_level.py

+    def _default_language(self):
+        lang_code = self.env["ir.default"]._get("res.partner", "lang")
+        def_lang_id = self.env["res.lang"]._get_data(code=lang_code).id
+        return def_lang_id or self._active_languages()[0]


_active_languages does not exist in product.packaging.level.

thanks, it's fixed

nguyenminhchien suggested changes Dec 3, 2024

View reviewed changes

trisdoan mentioned this pull request Dec 4, 2024

[18.0][MIG] product_packaging_level_salable: Migration to 18.0 #6

Closed

rousseldenis and others added 26 commits December 5, 2024 14:25

[IMP] product_packaging_type: Rename to product_packaging_level

d0117a2

[IMP] product_packaging_level: Add migration scripts

8c00d13

[IMP] product_packaging_level: Improve README

86b3bb1

[UPD] Update product_packaging_level.pot

55d1fe5

oca-github-bot post-merge updates

afca35b

[FIX] product_packaging_level: Use correct field in hook

419e98d

oca-github-bot post-merge updates

5f011a9

[IMP] product_packaging_level: configure product packaging name

52f483e

[UPD] Update product_packaging_level.pot

0532b85

[BOT] post-merge updates

66fdda8

Added translation using Weblate (Italian)

1c3a17f

[16.0][FIX] product_packaging_level: Preserve sequence order

980ba69

[UPD] Update product_packaging_level.pot

3d424df

[BOT] post-merge updates

8784863

[IMP]product_packaging_level: recover name_get policy flow

97febd9

[UPD] Update product_packaging_level.pot

7415d98

[BOT] post-merge updates

55cb1e8

Ivorra78 and others added 6 commits December 5, 2024 14:25

[IMP] product_packaging_level: pre-commit auto fixes

cc45c62

[MIG] product_packaging_level: Migration to 17.0

8be3baf

[IMP] product_packaging_level: pre-commit auto fixes

c1d67bd

trisdoan force-pushed the 18.0-mig-product_packaging_level branch 3 times, most recently from 414c3d7 to 60da648 Compare December 5, 2024 08:11

trisdoan added 2 commits December 5, 2024 15:11

[MIG] product_packaging_level: Migration to 18.0

e4a1705

[FIX] product_packaging_level: cannot input name with user_defined po…

6ec3f39

…licy

trisdoan force-pushed the 18.0-mig-product_packaging_level branch from 60da648 to 6ec3f39 Compare December 5, 2024 08:12

trisdoan requested a review from nguyenminhchien December 5, 2024 08:15

nguyenminhchien approved these changes Dec 6, 2024

View reviewed changes

trisdoan closed this Dec 9, 2024

thienvh332 reviewed Dec 12, 2024

View reviewed changes

	<field name="barcode_required_for_gtin" invisible="1" />
	<field name="barcode_required_for_gtin" column_invisible="1" />

	<attribute name="invisible">1</attribute>
	<attribute name="column_invisible">1</attribute>

	msg = _('There must be one product packaging level set as "Is Default".')
	msg = self.env._('There must be one product packaging level set as "Is Default".')

	msg = _('Only one product packaging level can be set as "Is Default".')
	msg = self.env._('Only one product packaging level can be set as "Is Default".')

Conversation

trisdoan commented Nov 29, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes in 18.0

Uh oh!

nguyenminhchien left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

nguyenminhchien commented Dec 3, 2024

Uh oh!

nguyenminhchien commented Dec 3, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

trisdoan commented Dec 5, 2024

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

trisdoan commented Nov 29, 2024 •

edited

Loading

nguyenminhchien commented Dec 3, 2024 •

edited

Loading