[18.0][MIG] product_packaging_level_salable: Migration to 18.0#6
Closed
[18.0][MIG] product_packaging_level_salable: Migration to 18.0#6
Conversation
Currently translated at 100.0% (10 of 10 strings) Translation: product-attribute-16.0/product-attribute-16.0-product_packaging_level_salable Translate-URL: https://translation.odoo-community.org/projects/product-attribute-16-0/product-attribute-16-0-product_packaging_level_salable/it/
Currently translated at 100.0% (10 of 10 strings) Translation: product-attribute-16.0/product-attribute-16.0-product_packaging_level_salable Translate-URL: https://translation.odoo-community.org/projects/product-attribute-16-0/product-attribute-16-0-product_packaging_level_salable/es/
trisdoan
force-pushed
the
18.0-mig-product_packaging_level_salable
branch
from
3d7aedb to
f8d08b1
Compare
This was referenced Dec 4, 2024
xaviedoanhduy
suggested changes
Dec 6, 2024
| for line in self: | ||
| if line._can_be_sold_error_condition(): | ||
| raise ValidationError( | ||
| _( |
There was a problem hiding this comment.
You can replace the call to translate a string (_) with self.env._ for getting some performance improvement in some cases. See odoo/odoo#174844.
| if self._can_be_sold_error_condition(): | ||
| return { | ||
| "warning": { | ||
| "title": _("Warning"), |
| @classmethod | ||
| def setUpClass(cls): | ||
| super().setUpClass() | ||
| cls.env = cls.env(context=dict(cls.env.context, tracking_disable=True)) |
There was a problem hiding this comment.
FYI, to avoid the tracking_disable context, you can use BaseCommon class
from odoo.addons.base.tests.common import BaseCommon
trisdoan
force-pushed
the
18.0-mig-product_packaging_level_salable
branch
from
f8d08b1 to
0a80b01
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
https://github.com/OCA/product-attribute/pull/1669