[Test] Stop ignoring exceptions thrown in snapshot tests #355
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 2, 2025
test-setup/run_spec.js
Outdated
| } catch (e) { | ||
| console.error(e, path); | ||
| } | ||
| expect( |
Collaborator
There was a problem hiding this comment.
Thanks for suggestion! I totally agreed that ignoring is bad practice, but could we keep try-catch block and throw a different error for enhancing maintainability?
Suggested change
| expect( | |
| try { | |
| expect( | |
| raw(source + '~'.repeat(80) + '\n' + (await output)), | |
| ).toMatchSnapshot(filename); | |
| } catch (e) { | |
| throw new Error(`Problem occurred in ${path} file: ${error.name}`) | |
| } |
ckwalsh
force-pushed
the
pr355
branch
2 times, most recently
from
3f3163a to
ff247e1
Compare
Summary: This logic can hide breakages and cause tests to pass when the underlying logic is actually broken. I encountered these hidden breakages while working on some further feature changes, and figured it was appropriate to fix this first. As all existing tests pass without the try/catch, this change is effectively a no-op. Test Plan: `yarn install && yarn run test ./tests/`
vladislavarsenev
force-pushed
the
pr355
branch
from
ff247e1 to
371e9f5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This logic can hide breakages and cause tests to pass when the
underlying logic is actually broken. I encountered these hidden
breakages while working on some further feature changes, and figured
it was appropriate to fix this first.
As all existing tests pass without the try/catch, this change is
effectively a no-op.
Test Plan:
yarn install && yarn run test ./tests/Stack created with Sapling. Best reviewed with ReviewStack.
sort-imports-ignore#358