[Perf] Improve performance of removeNodesFromOriginalCode() #356
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 2, 2025
ckwalsh
force-pushed
the
pr356
branch
2 times, most recently
from
b8bdfa3 to
042f1a0
Compare
Summary:
This change replaces the existing RegExp replace() logic with
concatenated string slices. This avoids reallocation the result
string for each node replacement, replacing it with string slice
operations (which are implemented as O(1) string views within v8) and
a single .join(''), which can be optimized by the runtime to a single
allocation.
This probably won't make a noticable difference, but the change also
simplifies some further feature work I am attempting to add.
Test Plan:
`yarn install && yarn run test --all`
vladislavarsenev
force-pushed
the
pr356
branch
from
042f1a0 to
9266fdb
Compare
Collaborator
|
Like this approach, thank you🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This change replaces the existing RegExp replace() logic with
concatenated string slices. This avoids reallocation the result
string for each node replacement, replacing it with string slice
operations (which are implemented as O(1) string views within v8) and
a single .join(''), which can be optimized by the runtime to a single
allocation.
This probably won't make a noticable difference, but the change also
simplifies some further feature work I am attempting to add.
Test Plan:
yarn install && yarn run test --allStack created with Sapling. Best reviewed with ReviewStack.
sort-imports-ignore#358