Skip to content

Add function requires_update#105

Merged
LasNikas merged 6 commits intomainfrom
ef/requires-update
Apr 15, 2025
Merged

Add function requires_update#105
LasNikas merged 6 commits intomainfrom
ef/requires-update

Conversation

@efaulhaber
Copy link
Copy Markdown
Member

No description provided.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

Files not reviewed (5)
  • src/PointNeighbors.jl: Language not supported
  • src/neighborhood_search.jl: Language not supported
  • src/nhs_grid.jl: Language not supported
  • src/nhs_precomputed.jl: Language not supported
  • src/nhs_trivial.jl: Language not supported

@efaulhaber efaulhaber self-assigned this Apr 10, 2025
@efaulhaber efaulhaber added the enhancement New feature or request label Apr 10, 2025
@codecov
Copy link
Copy Markdown

codecov bot commented Apr 10, 2025

Codecov Report

Attention: Patch coverage is 41.66667% with 14 lines in your changes missing coverage. Please review.

Project coverage is 86.71%. Comparing base (596f50f) to head (431e39f).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/nhs_grid.jl 28.57% 5 Missing ⚠️
src/neighborhood_search.jl 50.00% 4 Missing ⚠️
src/nhs_precomputed.jl 57.14% 3 Missing ⚠️
src/nhs_trivial.jl 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #105      +/-   ##
==========================================
- Coverage   88.60%   86.71%   -1.89%     
==========================================
  Files          15       15              
  Lines         544      557      +13     
==========================================
+ Hits          482      483       +1     
- Misses         62       74      +12     
Flag Coverage Δ
unit 86.71% <41.66%> (-1.89%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@efaulhaber
Copy link
Copy Markdown
Member Author

@LasNikas I also added requires_resizing, which you can use with the buffer in TrixiParticles:

if requires_resizing(nhs)
    # Use `Inf` values for inactive particles
else
    update!(nhs, particles, active_neighbors)
end

@LasNikas LasNikas merged commit 3a95fe0 into main Apr 15, 2025
10 of 12 checks passed
@LasNikas LasNikas deleted the ef/requires-update branch April 15, 2025 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants