Add full support for parallelization backends#109
Merged
efaulhaber merged 9 commits intomainfrom May 7, 2025
Merged
Conversation
efaulhaber
added
the
breaking changes
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #109 +/- ##
==========================================
+ Coverage 86.78% 88.66% +1.87%
==========================================
Files 15 14 -1
Lines 560 547 -13
==========================================
- Hits 486 485 -1
+ Misses 74 62 -12
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
Copilot reviewed 1 out of 17 changed files in this pull request and generated no comments.
Files not reviewed (16)
- benchmarks/count_neighbors.jl: Language not supported
- benchmarks/n_body.jl: Language not supported
- benchmarks/plot.jl: Language not supported
- benchmarks/smoothed_particle_hydrodynamics.jl: Language not supported
- benchmarks/update.jl: Language not supported
- src/PointNeighbors.jl: Language not supported
- src/cell_lists/full_grid.jl: Language not supported
- src/gpu.jl: Language not supported
- src/neighborhood_search.jl: Language not supported
- src/nhs_grid.jl: Language not supported
- src/nhs_precomputed.jl: Language not supported
- src/nhs_trivial.jl: Language not supported
- src/util.jl: Language not supported
- test/cell_lists/full_grid.jl: Language not supported
- test/neighborhood_search.jl: Language not supported
- test/nhs_grid.jl: Language not supported
Contributor
There was a problem hiding this comment.
Copilot reviewed 1 out of 17 changed files in this pull request and generated no comments.
Files not reviewed (16)
- benchmarks/count_neighbors.jl: Language not supported
- benchmarks/n_body.jl: Language not supported
- benchmarks/plot.jl: Language not supported
- benchmarks/smoothed_particle_hydrodynamics.jl: Language not supported
- benchmarks/update.jl: Language not supported
- src/PointNeighbors.jl: Language not supported
- src/cell_lists/full_grid.jl: Language not supported
- src/gpu.jl: Language not supported
- src/neighborhood_search.jl: Language not supported
- src/nhs_grid.jl: Language not supported
- src/nhs_precomputed.jl: Language not supported
- src/nhs_trivial.jl: Language not supported
- src/util.jl: Language not supported
- test/cell_lists/full_grid.jl: Language not supported
- test/neighborhood_search.jl: Language not supported
- test/nhs_grid.jl: Language not supported
Member
Author
|
Tests are failing until trixi-framework/TrixiParticles.jl#790 is merged, which is based on this PR, so we will need to ignore these fails for now. |
svchb
requested changes
May 6, 2025
Co-authored-by: Sven Berger <berger.sven@gmail.com>
Co-authored-by: Sven Berger <berger.sven@gmail.com>
svchb
approved these changes
May 6, 2025
LasNikas
approved these changes
May 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SerialBackend.@threadedAPI to only allow backends as first argument and not arrays. This is a breaking change.parallelization_backendtoinitialize!and to docs (and removed experimental warning).parellelofforeach_point_neighbortoparallelization_backendand removed support for booleans likeparallel = true. This is a breaking change.FullGridCellListout of bounds (on CPUs only).requires_resizing(@LasNikas requested it but didn't need it at the end). This is a breaking change.