Add full support for parallelization backends#790
Merged
svchb merged 14 commits intotrixi-framework:mainfrom May 8, 2025
Merged
Add full support for parallelization backends#790svchb merged 14 commits intotrixi-framework:mainfrom
svchb merged 14 commits intotrixi-framework:mainfrom
Conversation
This was referenced May 6, 2025
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #790 +/- ##
==========================================
+ Coverage 70.61% 70.62% +0.01%
==========================================
Files 103 103
Lines 6618 6611 -7
==========================================
- Hits 4673 4669 -4
+ Misses 1945 1942 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
Author
|
/run-gpu-tests |
Member
Author
|
/run-gpu-tests |
There was a problem hiding this comment.
Pull Request Overview
This PR adds full support for parallelization backends by updating threaded loops, modifying constructors, and adjusting example and documentation files to use explicit backend types rather than booleans.
- Replace “@threaded positions…” with “@threaded default_backend(positions)” in various modules.
- Update function signatures and type checks in semidiscretization to use explicit backend types.
- Amend examples and documentation to use backend constructors (e.g., PolyesterBackend, SerialBackend) instead of primitive booleans.
Reviewed Changes
Copilot reviewed 31 out of 31 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/preprocessing/particle_packing/signed_distance.jl | Updated threaded loop to use default_backend for FaceNeighborhoodSearch. |
| src/preprocessing/geometries/triangle_mesh.jl | Updated threaded loops to use default_backend for face_vertices and vertices_sorted arrays. |
| src/general/semidiscretization.jl | Modified the Semidiscretization constructor and semidiscretize function; now uses explicit parallelization_backend type checks. |
| src/general/neighborhood_search.jl | Changed foreach_point_neighbor call to use the new parallelization_backend parameter. |
| src/general/initial_condition.jl | Updated foreach_point_neighbor calls to use SerialBackend instead of a boolean flag. |
| src/TrixiParticles.jl | Updated re-exports to include new backend types and default_backend. |
| Examples (various) | Replaced boolean flag with explicit backend constructors for simulation setups. |
| docs/* | Adjusted documentation and Project.toml to reflect the new backend usage. |
LasNikas
reviewed
May 8, 2025
Member
Author
|
/run-gpu-tests |
LasNikas
approved these changes
May 8, 2025
svchb
approved these changes
May 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on trixi-framework/PointNeighbors.jl#109.