Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #118 +/- ##
=======================================
Coverage 87.94% 87.94%
=======================================
Files 15 15
Lines 622 622
=======================================
Hits 547 547
Misses 75 75
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull Request Overview
This PR improves the benchmarking code by enhancing the particle distribution perturbation, updating benchmark functions to use a realistic search radius, and introducing both default and GPU benchmark runs. The key changes include updating the perturbation logic in point cloud generation, refactoring benchmark functions to pass a parallelization backend, and replacing the old plotting module with a new run_benchmarks module.
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| test/point_cloud.jl | Adjusted the perturbation factor and updated the perturb! function to use a normal distribution. |
| test/benchmarks.jl | Replaced plot-based benchmark calls with run_benchmark_default and added GPU benchmark calls. |
| benchmarks/update.jl | Modified the benchmark_initialize and update_alternating! functions to use a parallelization_backend. |
| benchmarks/smoothed_particle_hydrodynamics.jl | Refactored the WCSPH benchmark to delegate to an inner function and update particle_spacing usage. |
| benchmarks/run_benchmarks.jl | Introduced new benchmarking routines and plotting support. |
| benchmarks/plot.jl | Removed in favor of the new run_benchmarks.jl module. |
| benchmarks/n_body.jl | Updated function signature for benchmark_n_body to accept a parallelization_backend. |
| benchmarks/count_neighbors.jl | Updated function signature for benchmark_count_neighbors similarly. |
| benchmarks/benchmarks.jl | Redirected the include directive to load run_benchmarks.jl instead of the deprecated plot.jl. |
Comments suppressed due to low confidence (1)
benchmarks/run_benchmarks.jl:40
- There is an extra trailing apostrophe after the array comprehension for names. Remove the apostrophe and use commas for separation to ensure correct array syntax.
names = ["NeighborhoodSearch $i" for i in 1:length(neighborhood_searches)]',
…ixiNeighborhoodSearch.jl into ef/improve-benchmarks
This PR improves the usability of the benchmarking code, makes the particle distribution more realistic, and uses a more realistic search radius of 4 x spacing.