Skip to content

Improve benchmarking code#118

Merged
efaulhaber merged 14 commits intomainfrom
ef/improve-benchmarks
Sep 5, 2025
Merged

Improve benchmarking code#118
efaulhaber merged 14 commits intomainfrom
ef/improve-benchmarks

Conversation

@efaulhaber
Copy link
Copy Markdown
Member

This PR improves the usability of the benchmarking code, makes the particle distribution more realistic, and uses a more realistic search radius of 4 x spacing.

@codecov
Copy link
Copy Markdown

codecov bot commented May 26, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.94%. Comparing base (70dfeab) to head (5daba76).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #118   +/-   ##
=======================================
  Coverage   87.94%   87.94%           
=======================================
  Files          15       15           
  Lines         622      622           
=======================================
  Hits          547      547           
  Misses         75       75           
Flag Coverage Δ
unit 87.94% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@efaulhaber efaulhaber requested review from LasNikas, Copilot and svchb May 28, 2025 08:46
@efaulhaber efaulhaber self-assigned this May 28, 2025
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR improves the benchmarking code by enhancing the particle distribution perturbation, updating benchmark functions to use a realistic search radius, and introducing both default and GPU benchmark runs. The key changes include updating the perturbation logic in point cloud generation, refactoring benchmark functions to pass a parallelization backend, and replacing the old plotting module with a new run_benchmarks module.

Reviewed Changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
test/point_cloud.jl Adjusted the perturbation factor and updated the perturb! function to use a normal distribution.
test/benchmarks.jl Replaced plot-based benchmark calls with run_benchmark_default and added GPU benchmark calls.
benchmarks/update.jl Modified the benchmark_initialize and update_alternating! functions to use a parallelization_backend.
benchmarks/smoothed_particle_hydrodynamics.jl Refactored the WCSPH benchmark to delegate to an inner function and update particle_spacing usage.
benchmarks/run_benchmarks.jl Introduced new benchmarking routines and plotting support.
benchmarks/plot.jl Removed in favor of the new run_benchmarks.jl module.
benchmarks/n_body.jl Updated function signature for benchmark_n_body to accept a parallelization_backend.
benchmarks/count_neighbors.jl Updated function signature for benchmark_count_neighbors similarly.
benchmarks/benchmarks.jl Redirected the include directive to load run_benchmarks.jl instead of the deprecated plot.jl.
Comments suppressed due to low confidence (1)

benchmarks/run_benchmarks.jl:40

  • There is an extra trailing apostrophe after the array comprehension for names. Remove the apostrophe and use commas for separation to ensure correct array syntax.
                       names = ["NeighborhoodSearch $i" for i in 1:length(neighborhood_searches)]',

Comment thread benchmarks/run_benchmarks.jl
@efaulhaber efaulhaber added the enhancement New feature or request label May 28, 2025
Comment thread benchmarks/run_benchmarks.jl Outdated
Comment thread benchmarks/run_benchmarks.jl Outdated
@efaulhaber efaulhaber merged commit edf29bb into main Sep 5, 2025
12 checks passed
@efaulhaber efaulhaber deleted the ef/improve-benchmarks branch September 5, 2025 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants