Refactor SPH system initialization to use keyword arguments#1144
Open
svchb wants to merge 3 commits intotrixi-framework:devfrom
Open
Refactor SPH system initialization to use keyword arguments#1144svchb wants to merge 3 commits intotrixi-framework:devfrom
svchb wants to merge 3 commits intotrixi-framework:devfrom
Conversation
- Updated the initialization of `WeaklyCompressibleSPHSystem` and `EntropicallyDampedSPHSystem` across multiple examples to utilize keyword arguments for better readability and maintainability. - Adjusted the documentation for both systems to reflect the new argument structure. - Ensured consistency in the usage of density calculators and state equations in the examples. - Modified tests to validate the new keyword argument structure for both SPH systems.
svchb
added
the
breaking changes
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## dev #1144 +/- ##
======================================
Coverage ? 89.13%
======================================
Files ? 128
Lines ? 9935
Branches ? 0
======================================
Hits ? 8856
Misses ? 1079
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
efaulhaber
requested changes
Apr 20, 2026
Comment on lines
+124
to
+125
| smoothing_kernel=smoothing_kernel, | ||
| smoothing_length=smoothing_length, |
Member
There was a problem hiding this comment.
Suggested change
| smoothing_kernel=smoothing_kernel, | |
| smoothing_length=smoothing_length, | |
| smoothing_kernel, smoothing_length, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WeaklyCompressibleSPHSystemandEntropicallyDampedSPHSystemacross multiple examples to utilize keyword arguments for better readability and maintainability.