Reopen #363: Hydrostatic water column (FSI)#441
Reopen #363: Hydrostatic water column (FSI)#441LasNikas wants to merge 21 commits intotrixi-framework:mainfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #441 +/- ##
=======================================
Coverage 68.88% 68.88%
=======================================
Files 86 86
Lines 5261 5261
=======================================
Hits 3624 3624
Misses 1637 1637
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
@efaulhaber and @svchb do we need this example or should I close this PR? |
|
I am fine with adding this example if the results are correct. |
|
What is this again? Was it the hydrostatic water column resting on an elastic beam? I'm against merging more examples that we don't really need. I prefer having useful validation examples from the literature only. Trixi.jl has too many examples, which makes it really hard for beginners. |
|
Niklas and I as far as I know are not against having as many examples as possible. But of course we would need to restructure the examples folder structure + docs page at some point. |
|
It's a validation example from Sun et al. (2019), as well as from O'Connor and Rogers (2021). |
Please add this as a comment and a description of what that simulation does. |
|
Superseeded by #724 |
No description provided.