Skip to content

Validation hydrostatic water column#724

Merged
LasNikas merged 121 commits intotrixi-framework:mainfrom
svchb:validation_hydrostatic_water_column
Mar 9, 2026
Merged

Validation hydrostatic water column#724
LasNikas merged 121 commits intotrixi-framework:mainfrom
svchb:validation_hydrostatic_water_column

Conversation

@svchb
Copy link
Copy Markdown
Collaborator

@svchb svchb commented Feb 21, 2025

superseeds #441

image

@svchb svchb self-assigned this Feb 21, 2025
@svchb svchb mentioned this pull request Feb 21, 2025
Closed
@svchb
Copy link
Copy Markdown
Collaborator Author

svchb commented Feb 21, 2025

I will recreate the json files with a lower number of points.

svchb added 2 commits February 21, 2025 02:54
@svchb
format
ddac0e9
@svchb
Merge branch 'validation_hydrostatic_water_column' of github.com:svch…
5be95b7 
…b/TrixiParticles.jlOpen into validation_hydrostatic_water_column
@sloede
Copy link
Copy Markdown
Member

sloede commented Feb 21, 2025

This looks very promising! Is there a way to augment these results with reference data from the literature within the same plots?

@LasNikas
Copy link
Copy Markdown
Collaborator

LasNikas commented Feb 21, 2025

AFAIK, this is from Sun 2019 and also O'Connor 2021
The problem is that EDAC or a simple DDT can't deal with steady states. Over time, the particles will diffuse.
That was my observation when I was setting up this example.

@svchb
Copy link
Copy Markdown
Collaborator Author

svchb commented Feb 21, 2025 •
edited
Loading

As mentioned in the setup I have used the setup from O'Connor 2021. The error magnitude data is extracted from Fig. 8 .

@svchb
Copy link
Copy Markdown
Collaborator Author

svchb commented Feb 21, 2025

AFAIK, this is from Sun 2019 and also O'Connor 2021 The problem is that EDAC or a simple DDT can't deal with steady states. Over time, the particles will diffuse. That was my observation when I was setting up this example.

Not within the timeframe from 0.0 to 1.0. So this works fine with the same setup that O'Connor shows.

@sloede
Copy link
Copy Markdown
Member

sloede commented Feb 21, 2025

As mentioned in the setup I have used the setup from O'Connor 2021. The error magnitude data is extracted from Fig. 8 .

Ah, the "reference" is already literature data? Nice 👍 Would be awesome to get a second data point that can be directly compared with literature.

@svchb
Copy link
Copy Markdown
Collaborator Author

svchb commented Feb 21, 2025

As mentioned in the setup I have used the setup from O'Connor 2021. The error magnitude data is extracted from Fig. 8 .

Ah, the "reference" is already literature data? Nice 👍 Would be awesome to get a second data point that can be directly compared with literature.

Yes it is. It just takes a long time. The next point that is close takes 6-8 hours per model.

@LasNikas
Copy link
Copy Markdown
Collaborator

LasNikas commented Feb 21, 2025

This might be a really nice validation for a multi resolution FSI example.
As @svchb mentioned, it takes a long time. This is due to the high water column directly sampled with particles basically being in a steady state.

@svchb
Copy link
Copy Markdown
Collaborator Author

svchb commented Feb 23, 2025

Not working with even particle resolutions. Not sure why? I fixed the problem with determining the midpoint but there is something else not correct...
image

efaulhaber
efaulhaber previously approved these changes Feb 23, 2026
View reviewed changes
@svchb
Copy link
Copy Markdown
Collaborator Author

svchb commented Feb 23, 2026

/run-gpu-tests

@svchb
Copy link
Copy Markdown
Collaborator Author

svchb commented Feb 23, 2026

/run-gpu-tests

@svchb
Copy link
Copy Markdown
Collaborator Author

svchb commented Feb 24, 2026

/run-gpu-tests

@svchb
Copy link
Copy Markdown
Collaborator Author

svchb commented Feb 25, 2026

/run-gpu-tests

LasNikas
LasNikas reviewed Feb 27, 2026
View reviewed changes
Copy link
Copy Markdown
Collaborator

@LasNikas LasNikas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are the results up to date? The PR was created a year ago...

Comment thread src/general/custom_quantities.jl
@svchb
Copy link
Copy Markdown
Collaborator Author

svchb commented Feb 27, 2026 •
edited
Loading

Are the results up to date? The PR was created a year ago...

The reference files have been updated since the creation of the PR.

@svchb svchb requested a review from LasNikas February 27, 2026 16:15
@svchb
Copy link
Copy Markdown
Collaborator Author

svchb commented Feb 28, 2026

/run-gpu-tests

@LasNikas
Copy link
Copy Markdown
Collaborator

LasNikas commented Mar 3, 2026

The reference files have been updated since the creation of the PR.

If I've looked at it correctly, the last update of the results was 12 months ago (ad2cddc).

@svchb
Copy link
Copy Markdown
Collaborator Author

svchb commented Mar 3, 2026

The reference files have been updated since the creation of the PR.

If I've looked at it correctly, the last update of the results was 12 months ago (ad2cddc).

If you check the metadata of the linked commit you will find this is not identical to the current files which have been produced with the current version of Julia.

@svchb
Copy link
Copy Markdown
Collaborator Author

svchb commented Mar 5, 2026

/run-gpu-tests

@svchb
Copy link
Copy Markdown
Collaborator Author

svchb commented Mar 5, 2026

/run-gpu-tests

@svchb
Copy link
Copy Markdown
Collaborator Author

svchb commented Mar 5, 2026

/run-gpu-tests

@svchb
Copy link
Copy Markdown
Collaborator Author

svchb commented Mar 6, 2026

/run-gpu-tests

@LasNikas LasNikas enabled auto-merge (squash) March 9, 2026 12:02
@LasNikas LasNikas merged commit 71da8bc into trixi-framework:main Mar 9, 2026
23 of 24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@efaulhaber efaulhaber efaulhaber left review comments

@LasNikas LasNikas LasNikas approved these changes

Assignees

@svchb svchb

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@svchb @sloede @LasNikas @efaulhaber