Skip to content

Fix Validation Setups#801

Merged
svchb merged 31 commits intotrixi-framework:mainfrom
svchb:fix_validation
May 28, 2025
Merged

Fix Validation Setups#801
svchb merged 31 commits intotrixi-framework:mainfrom
svchb:fix_validation

Conversation

@svchb
Copy link
Copy Markdown
Collaborator

@svchb svchb commented May 13, 2025

No description provided.

@svchb svchb requested review from LasNikas and efaulhaber May 13, 2025 12:52
@svchb svchb self-assigned this May 13, 2025
@svchb svchb added the bug Something isn't working label May 13, 2025
@codecov
Copy link
Copy Markdown

codecov bot commented May 13, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.74%. Comparing base (a73e6c4) to head (fb689b3).

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #801   +/-   ##
=======================================
  Coverage   70.74%   70.74%           
=======================================
  Files         106      106           
  Lines        6710     6710           
=======================================
  Hits         4747     4747           
  Misses       1963     1963
Flag Coverage Δ
unit 70.74% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@svchb svchb mentioned this pull request May 13, 2025
Merged
@svchb
Copy link
Copy Markdown
Collaborator Author

svchb commented May 14, 2025

/run-gpu-tests

@svchb
Copy link
Copy Markdown
Collaborator Author

svchb commented May 16, 2025

/run-gpu-tests

LasNikas
LasNikas reviewed May 19, 2025
View reviewed changes
Comment thread validation/taylor_green_vortex_2d/validation_taylor_green_vortex_2d.jl Outdated
@svchb svchb requested a review from LasNikas May 19, 2025 11:07
@svchb
Copy link
Copy Markdown
Collaborator Author

svchb commented May 21, 2025

/run-gpu-tests

@svchb
Copy link
Copy Markdown
Collaborator Author

svchb commented May 21, 2025

/run-gpu-tests

LasNikas
LasNikas previously approved these changes May 21, 2025
View reviewed changes
efaulhaber
efaulhaber requested changes May 21, 2025
View reviewed changes
Comment thread validation/lid_driven_cavity_2d/validation_lid_driven_cavity_2d.jl
Comment thread validation/taylor_green_vortex_2d/validation_taylor_green_vortex_2d.jl Outdated
@svchb svchb requested review from LasNikas and efaulhaber May 21, 2025 12:31
efaulhaber
efaulhaber requested changes May 21, 2025
View reviewed changes
Comment thread validation/taylor_green_vortex_2d/validation_taylor_green_vortex_2d.jl Outdated
Comment thread test/validation/validation.jl Outdated
Comment thread validation/lid_driven_cavity_2d/validation_lid_driven_cavity_2d.jl
Comment thread test/validation/validation.jl Outdated
@svchb svchb requested a review from efaulhaber May 22, 2025 07:49
efaulhaber
efaulhaber requested changes May 23, 2025
View reviewed changes
Comment thread validation/lid_driven_cavity_2d/validation_lid_driven_cavity_2d.jl Outdated
Comment thread validation/lid_driven_cavity_2d/validation_lid_driven_cavity_2d.jl Outdated
Comment thread validation/lid_driven_cavity_2d/validation_lid_driven_cavity_2d.jl Outdated
Comment thread validation/taylor_green_vortex_2d/validation_taylor_green_vortex_2d.jl Outdated
Comment thread validation/taylor_green_vortex_2d/validation_taylor_green_vortex_2d.jl Outdated
@svchb svchb requested a review from efaulhaber May 23, 2025 14:34
@svchb
Copy link
Copy Markdown
Collaborator Author

svchb commented May 27, 2025

/run-gpu-tests

@svchb svchb merged commit 7cb3055 into trixi-framework:main May 28, 2025
16 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@efaulhaber efaulhaber efaulhaber approved these changes

@LasNikas LasNikas Awaiting requested review from LasNikas

Assignees

@svchb svchb

Labels

bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@svchb @efaulhaber @LasNikas