Skip to content

Make interpolation with different smoothing length work on the GPU#952

Open
efaulhaber wants to merge 9 commits intotrixi-framework:mainfrom
efaulhaber:interpolation-gpu
Open

Make interpolation with different smoothing length work on the GPU#952
efaulhaber wants to merge 9 commits intotrixi-framework:mainfrom
efaulhaber:interpolation-gpu

Conversation

@efaulhaber
Copy link
Copy Markdown
Member

@efaulhaber efaulhaber commented Oct 13, 2025

fixes #950

@efaulhaber efaulhaber self-assigned this Oct 13, 2025
@efaulhaber efaulhaber added bug Something isn't working gpu labels Oct 13, 2025
@efaulhaber efaulhaber marked this pull request as ready for review October 14, 2025 13:31
@efaulhaber efaulhaber requested review from LasNikas and svchb October 14, 2025 13:31
Copy link
Copy Markdown
Collaborator

@svchb svchb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add a test?

@codecov
Copy link
Copy Markdown

codecov bot commented Nov 18, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.71%. Comparing base (2277802) to head (52b12bf).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #952      +/-   ##
==========================================
- Coverage   88.72%   88.71%   -0.01%     
==========================================
  Files         128      128              
  Lines        9745     9747       +2     
==========================================
+ Hits         8646     8647       +1     
- Misses       1099     1100       +1     
Flag Coverage Δ
total 88.71% <100.00%> (-0.01%) ⬇️
unit 66.99% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@svchb
Copy link
Copy Markdown
Collaborator

svchb commented Nov 21, 2025

/run-gpu-tests

@svchb svchb self-requested a review November 21, 2025 17:40
@svchb
Copy link
Copy Markdown
Collaborator

svchb commented Nov 21, 2025

/run-gpu-tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working gpu

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Interpolation with a different smoothing length than the computation is broken

2 participants