Skip to content

[18.0][MIG] coop_membership_extension_limit: Migration to 18.0#30

Merged
nguyenminhchien merged 2 commits into18.0_devfrom
F#T66189
Apr 6, 2026
Merged

[18.0][MIG] coop_membership_extension_limit: Migration to 18.0#30
nguyenminhchien merged 2 commits into18.0_devfrom
F#T66189

Conversation

@P-H-Phuc
Copy link
Copy Markdown

No description provided.

Copy link
Copy Markdown
Collaborator

@nguyenminhchien nguyenminhchien left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Add unit tests

<field name="inherit_id" ref="coop_membership.res_config_settings_view_form" />
<field name="arch" type="xml">
<xpath expr="//block[@name='membership_settings']" position="inside">
<setting id="member_extension_limit">
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<setting id="member_extension_limit">
<setting id="member_extension_limit"
help="Limit the extension for specific types">
<field name="member_extension_limit" />
<field
name="member_extension_limit_type_ids"
invisible="not member_extension_limit"
required="member_extension_limit"
widget="many2many_tags"
placeholder="Extension Limit Types"
/>
</setting>

remove <setting id="member_extension_limit_count"> below

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need to remove member_extension_limit_count?

@@ -0,0 +1,37 @@
<?xml version="1.0" ?>
<odoo noupdate="0">
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
<odoo noupdate="0">
<odoo noupdate="1">

@P-H-Phuc P-H-Phuc requested a review from nguyenminhchien April 6, 2026 04:05
@nguyenminhchien nguyenminhchien merged commit a4c98b1 into 18.0_dev Apr 6, 2026
2 of 4 checks passed
@nguyenminhchien nguyenminhchien deleted the F#T66189 branch April 6, 2026 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants