Select links with bdi child element for MusicBrainz entries if possible#316
Open
StormPooper wants to merge 4 commits intotrossr32:stagingfrom
Open
Select links with bdi child element for MusicBrainz entries if possible#316StormPooper wants to merge 4 commits intotrossr32:stagingfrom
StormPooper wants to merge 4 commits intotrossr32:stagingfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have the Link Harmony release actions UserScript in Tampermonkey, which adds a link to Harmony in the release header if it finds an entry on the site. The extension was picking this element up due to lack of selector specificity, so I've updated the extension logic to try to be more specific if we have browser support and fall back to the original behaviour if not (as the extension does support versions older than
:hassupport goes back). I also removed the direct descendanth1 > aas it seems some pages wrap theain aspan, so I instead focused on thebdichild element, which all 3 seem to have from my testing - I've verified the test URLs inmusicbrainz.spec.tsall still work.Before (icon URL contains Harmony URL):
After (correct Lidarr URL):
