Skip to content

Select links with bdi child element for MusicBrainz entries if possible #316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
StormPooper wants to merge 4 commits into
base: staging
Choose a base branch
from
Open

Select links with bdi child element for MusicBrainz entries if possible #316

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
eff86e8
Merge pull request #298 from trossr32/staging
Oct 16, 2025
3dd7b65
Select links with bdi element for MusicBrainz if possible
StormPooper Feb 7, 2026
36cdc1d
Merge branch 'trossr32:master' into musicbrainz-urls
StormPooper Feb 7, 2026
340bc46
Comment explaining fallback
StormPooper Feb 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions src/content/engines/integrations/musicbrainz.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,11 @@

var Def = window.__servarrEngines.helpers.DefaultEngine;

function getHref(sel, doc) { var a = doc.querySelector(sel); return (a && a.href) || ''; }
function getHref(sel, doc) {
// Fall back to just selecting the link if we don't find it with `:has`, for browser support
var a = doc.querySelector(sel) || doc.querySelector(sel.replace(/:has\([^)]+\)/g, ''));
return (a && a.href) || '';
}

var Artist = Def({
id: 'musicbrainz',
Expand All @@ -14,7 +18,7 @@
insertWhere: 'prepend',
iconStyle: 'width: 26px; margin: 0 5px -4px 0;',
getSearch: function (_el, doc) {
var href = getHref('.artistheader > h1 > a', doc);
var href = getHref('.artistheader > h1 a:has(bdi)', doc);
return href ? href.replace('https://musicbrainz.org', '').replace('/artist/', 'lidarr:') : '';
}
});
Expand All @@ -28,7 +32,7 @@
insertWhere: 'prepend',
iconStyle: 'width: 26px; margin: 0 5px -4px 0;',
getSearch: function (_el, doc) {
var href = getHref('.rgheader > h1 > a', doc);
var href = getHref('.rgheader > h1 a:has(bdi)', doc);
return href ? href.replace('https://musicbrainz.org', '').replace('/release-group/', 'lidarr:') : '';
}
});
Expand All @@ -42,7 +46,7 @@
insertWhere: 'prepend',
iconStyle: 'width: 26px; margin: 0 5px -4px 0;',
getSearch: function (_el, doc) {
var href = getHref('.releaseheader > h1 > a', doc);
var href = getHref('.releaseheader > h1 a:has(bdi)', doc);
return href ? href.replace('https://musicbrainz.org', '').replace('/release/', 'lidarr:') : '';
}
});
Expand Down
Loading