Skip to content
This repository was archived by the owner on Sep 11, 2025. It is now read-only.

docs: Repo layout and contribution guide#47

Merged
carlosthe19916 merged 1 commit intotrustification:mainfrom
i386x:document-repo-layout
Jun 25, 2025
Merged

docs: Repo layout and contribution guide#47
carlosthe19916 merged 1 commit intotrustification:mainfrom
i386x:document-repo-layout

Conversation

@i386x
Copy link
Copy Markdown
Contributor

@i386x i386x commented Apr 1, 2025

Describe the repository layout and add a brief contribution guidelines.

Resolves: #43

* describe the repository layout
* describe how to contribute an API or a UI test

Resolves: trustification#43 (trustification#43)

Signed-off-by: Jiří Kučera <jkucera@redhat.com>

- `openapi.yaml` - a file with the [Trustify](https://github.com/trustification/trustify)
API definition; every time the file changes on the [Trustify](https://github.com/trustification/trustify)
side it should be also updated here
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As explained on elsewhere, atm we are not going to use the hey-api generated Sdk/Client/Types, due to overall preference of directly seeing the url/headers/params covered by api test inside the test code, instead of intermediate helpers.

As such, the is no need to keep this file updated ...
... depending on if we later find good use case for it, then it should be kept up to date (automatically), and if not then these parts can be dropped (for now since it was already implemented it can stay around until there is bigger progress and better understanding of maintaining the api tests).

Same would apply to following parts and sections too.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In case you guys find this useful https://github.com/trustification/trustify/blob/main/.github/workflows/openapi.yaml

That is the Gh Action that automatically pushes the openapi.yaml file to the UI repository to automatically. Just sharing in case you would like to have a similar thing here.

@carlosthe19916 carlosthe19916 merged commit ae30e85 into trustification:main Jun 25, 2025
4 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Only a fraction of the test suite is run

3 participants