This repository was archived by the owner on Sep 11, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 10
docs: Repo layout and contribution guide #47
Merged
carlosthe19916
merged 1 commit into
trustification:main
from
i386x:document-repo-layout
Jun 25, 2025
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As explained on elsewhere, atm we are not going to use the hey-api generated Sdk/Client/Types, due to overall preference of directly seeing the url/headers/params covered by api test inside the test code, instead of intermediate helpers.
As such, the is no need to keep this file updated ...
... depending on if we later find good use case for it, then it should be kept up to date (automatically), and if not then these parts can be dropped (for now since it was already implemented it can stay around until there is bigger progress and better understanding of maintaining the api tests).
Same would apply to following parts and sections too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In case you guys find this useful https://github.com/trustification/trustify/blob/main/.github/workflows/openapi.yaml
That is the Gh Action that automatically pushes the openapi.yaml file to the UI repository to automatically. Just sharing in case you would like to have a similar thing here.