Skip to content

Conversation

@omfj
Copy link
Contributor

@omfj omfj commented Nov 18, 2025

Moves the largest fields in the SetHeapMap to be the first fields in the struct.

@aapoalas
Copy link
Member

Did this have any effect in your performance measurements?

@omfj
Copy link
Contributor Author

omfj commented Nov 18, 2025

Actually no effect. Maybe not necessary then.

@omfj omfj marked this pull request as draft November 18, 2025 15:26
@aapoalas
Copy link
Member

Actually no effect. Maybe not necessary then.

Still a good idea.

@aapoalas aapoalas marked this pull request as ready for review November 18, 2025 15:30
Copy link
Member

@aapoalas aapoalas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@aapoalas aapoalas merged commit f38fb34 into trynova:main Nov 18, 2025
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants