Skip to content

refactor(set): move larger fields first #894

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 18, 2025
Merged

refactor(set): move larger fields first #894

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions nova_vm/src/ecmascript/builtins/set/data.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,10 +21,10 @@ use soavec_derive::SoAble;

#[derive(Debug, Default, SoAble)]
pub struct SetHeapData<'a> {
pub(crate) object_index: Option<OrdinaryObject<'a>>,
pub(crate) set_data: RefCell<HashTable<u32>>,
pub(crate) values: Vec<Option<Value<'a>>>,
pub(crate) object_index: Option<OrdinaryObject<'a>>,
/// Low-level hash table pointing to value indexes.
pub(crate) set_data: RefCell<HashTable<u32>>,
/// Flag that lets the Set know if it needs to rehash its primitive keys.
///
/// This happens when an object key needs to be moved in the set_data
Expand Down
Loading