Wire footprint insertion direction into PCB components and align board DRC fields#2165
Merged
ShiboSoftwareDev merged 11 commits intomainfrom Apr 23, 2026
Merged
Wire footprint insertion direction into PCB components and align board DRC fields#2165ShiboSoftwareDev merged 11 commits intomainfrom
ShiboSoftwareDev merged 11 commits intomainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
seveibar
reviewed
Apr 22, 2026
seveibar
reviewed
Apr 22, 2026
Contributor
seveibar
left a comment
seveibar
left a comment
There was a problem hiding this comment.
I think transformPcbElements should automatically perform this
ShiboSoftwareDev
changed the title
seveibar
reviewed
Apr 23, 2026
Contributor
seveibar
left a comment
seveibar
left a comment
There was a problem hiding this comment.
Can you take a look over this, you removed the ysage of the jlc spec module
seveibar
approved these changes
Apr 23, 2026
Contributor
seveibar
left a comment
seveibar
left a comment
There was a problem hiding this comment.
Undo jlc spec modifications
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Propagate footprint.insertionDirection onto pcb_component.insertion_direction using the component’s global pre-layout rotation plus bottom-side mirroring, and make primitive footprint flipping respect originalLayer so bottom-authored footprints and footprint constraints behave correctly. Bump @tscircuit/circuit-json-util to rely on its built-in PCB component transform updates.
Also align board manufacturing defaults and tests with the new *Clearance field names in circuit-json, replace the stale JLC tolerance import with a local helper, and add regression coverage for transformed insertion directions and originalLayer="bottom" footprint layout.