-
Notifications
You must be signed in to change notification settings - Fork 122
Wire footprint insertion direction into PCB components and align board DRC fields #2165
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 3 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
31d81d1
Wire footprint insertionDirection through PCB transforms
ShiboSoftwareDev 8e6a635
update types
ShiboSoftwareDev daac80d
update ss
ShiboSoftwareDev 4be1f21
update dep
ShiboSoftwareDev b7dbcab
merge
ShiboSoftwareDev 6301116
update ss
ShiboSoftwareDev e19f602
patch
ShiboSoftwareDev c99dd3a
patch
ShiboSoftwareDev e29462e
merge
ShiboSoftwareDev cd91e51
cleanup
ShiboSoftwareDev 1320676
update ss
ShiboSoftwareDev File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
29 changes: 29 additions & 0 deletions
29
...ts/primitive-components/Group/Group_doInitialPcbLayoutPack/updatePcbInsertionDirection.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,29 @@ | ||
| import type { CircuitJsonUtilObjects } from "@tscircuit/circuit-json-util" | ||
| import { transformFootprintInsertionDirection } from "lib/utils/pcb/transform-footprint-insertion-direction" | ||
|
|
||
| export const updatePcbInsertionDirection = ({ | ||
| db, | ||
| pcbComponentId, | ||
| rotationDegrees, | ||
| }: { | ||
| db: CircuitJsonUtilObjects | ||
| pcbComponentId: string | ||
| rotationDegrees: number | ||
| }) => { | ||
| if (rotationDegrees == null) return | ||
|
|
||
| const pcbComponent = db.pcb_component.get(pcbComponentId) | ||
| if (!pcbComponent?.insertion_direction) return | ||
|
|
||
| const nextDirection = transformFootprintInsertionDirection({ | ||
| insertionDirection: pcbComponent.insertion_direction, | ||
| rotationDegrees, | ||
| }) | ||
|
|
||
| if (!nextDirection) return | ||
|
|
||
| db.pcb_component.update(pcbComponentId, { | ||
| insertion_direction: nextDirection, | ||
| }) | ||
| pcbComponent.insertion_direction = nextDirection | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| import type { PcbBoard } from "circuit-json" | ||
|
|
||
| export type JlcToleranceMap = Partial<Record<keyof PcbBoard, number>> | ||
|
|
||
| export const jlcMinTolerances: JlcToleranceMap = { | ||
| min_trace_width: 0.1, | ||
| min_via_to_via_clearance: 0.1, | ||
| min_trace_to_pad_clearance: 0.1, | ||
| min_pad_to_pad_clearance: 0.1, | ||
| min_via_hole_diameter: 0.2, | ||
| min_via_pad_diameter: 0.3, | ||
| } |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.