improve PCB footprint and graphic processing for handling the other #41
Open
techmannih wants to merge 2 commits intotscircuit:mainfrom
Open
improve PCB footprint and graphic processing for handling the other #41techmannih wants to merge 2 commits intotscircuit:mainfrom
techmannih wants to merge 2 commits intotscircuit:mainfrom
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
techmannih
commented
Feb 28, 2026
| if (layerStr.includes("Silk")) { | ||
| type = side === "top" ? "top_silkscreen" : "bottom_silkscreen" | ||
| } else if (layerStr.includes("Edge.Cuts")) { | ||
| type = "edge_cuts" |
Member
Author
There was a problem hiding this comment.
TODO:
handling other layers
if (layerStr.includes("Silk")) {
type = side === "top" ? "top_silkscreen" : "bottom_silkscreen"
} else if (layerStr.includes("Fab")) {
type = side === "top" ? "top_fabrication_note" : "bottom_fabrication_note"
} else if (layerStr.includes("CrtYd") || layerStr.includes("Courtyard")) {
type = side === "top" ? "top_courtyard" : "bottom_courtyard"
} else if (layerStr.includes(".Cu")) {
type = side === "top" ? "top_copper" : "bottom_copper"
} else if (layerStr.includes("Mask")) {
type = side === "top" ? "top_soldermask" : "bottom_soldermask"
} else if (layerStr.includes("Edge.Cuts")) {
type = "edge_cuts"
}
techmannih
commented
Feb 28, 2026
| text: processedText, | ||
| anchor_position: pos, | ||
| layer: mapping.side, | ||
| anchor_alignment: "center", |
Member
Author
There was a problem hiding this comment.
TODO:
handling the anchor_alignment for pcb_silkscreen_text
techmannih
commented
Feb 28, 2026
Member
Author
There was a problem hiding this comment.
Here, remove extra silkscreen path which is not silkscreen, might be fab or courtyard. as shown in the kicad snapshot.
TODO:
add support fab and coutyard layer
techmannih
pushed a commit
to techmannih/kicad-to-circuit-json
that referenced
this pull request
Mar 21, 2026
Co-authored-by: GitHub Actions <actions@github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Key Changes
mapTextLayer,this.mapLayer) with a single, robust getLayerMapping utility in layer-utils.ts.Edge.Cutssupport to the centralized mapping to ensure board outlines are correctly identified and processed in CollectGraphicsStage.anchor_alignment: "center"to allpcb_silkscreen_textobjects. This provides a more accurate representation of KiCad's default text positioning and improves visual quality in renders.as anycasts in database insertion calls.