improve PCB footprint and graphic processing for handling the other layers#44
improve PCB footprint and graphic processing for handling the other layers#44techmannih wants to merge 2 commits intotscircuit:mainfrom
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 191a0674d8
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if (layerStr.includes("Silk")) { | ||
| type = side === "top" ? "top_silkscreen" : "bottom_silkscreen" | ||
| } else if (layerStr.includes("Edge.Cuts")) { | ||
| type = "edge_cuts" |
There was a problem hiding this comment.
TODO:
handling other layers
if (layerStr.includes("Silk")) {
type = side === "top" ? "top_silkscreen" : "bottom_silkscreen"
} else if (layerStr.includes("Fab")) {
type = side === "top" ? "top_fabrication_note" : "bottom_fabrication_note"
} else if (layerStr.includes("CrtYd") || layerStr.includes("Courtyard")) {
type = side === "top" ? "top_courtyard" : "bottom_courtyard"
} else if (layerStr.includes(".Cu")) {
type = side === "top" ? "top_copper" : "bottom_copper"
} else if (layerStr.includes("Mask")) {
type = side === "top" ? "top_soldermask" : "bottom_soldermask"
} else if (layerStr.includes("Edge.Cuts")) {
type = "edge_cuts"
}
| anchor_position: pos, | ||
| layer: mapping.side, | ||
| anchor_alignment: "center", | ||
| }) |
There was a problem hiding this comment.
TODO:
handling the anchor_alignment for pcb_silkscreen_text
There was a problem hiding this comment.
Here, remove extra silkscreen path which is not silkscreen, might be fab or courtyard. as shown in the kicad snapshot.
TODO:
add support fab and coutyard layer
There was a problem hiding this comment.
Here, remove extra silkscreen path which is not silkscreen, might be fab or courtyard. as shown in the kicad snapshot.
TODO:
add support fab and coutyard layer
There was a problem hiding this comment.
Here, remove extra silkscreen path which is not silkscreen, might be fab or courtyard. as shown in the kicad snapshot.
TODO:
add support fab and coutyard layer
techmannih
force-pushed
the
s
branch
3 times, most recently
from
dde8ce1 to
191a067
Compare
Co-authored-by: GitHub Actions <actions@github.com>
1 participant
Key Changes
mapTextLayer,this.mapLayer) with a single, robust getLayerMapping utility in layer-utils.ts.Edge.Cutssupport to the centralized mapping to ensure board outlines are correctly identified and processed in CollectGraphicsStage.anchor_alignment: "center"to allpcb_silkscreen_textobjects. This provides a more accurate representation of KiCad's default text positioning and improves visual quality in renders.as anycasts in database insertion calls.