This repository was archived by the owner on Nov 4, 2025. It is now read-only.
Open
Conversation
jpsyx
suggested changes
Aug 11, 2022
jpsyx
left a comment
jpsyx
left a comment
There was a problem hiding this comment.
A few minor fixes before we can merge :)
| <DatasetLink className="title" dataset={dataset}> | ||
| <h2>{formattedName}</h2> | ||
| <DatasetLink className="data-link-title title" dataset={dataset}> | ||
| <h2>{formattedName}</h2>asdf |
There was a problem hiding this comment.
Don't forget to remove the "asdf" on this line
Comment on lines
+4
to
+9
| .data-link-title{ | ||
| color:red; | ||
| &:focus-visible{ | ||
| color:aqua; | ||
| } | ||
| } |
There was a problem hiding this comment.
Don't forget the necessary spaces here after the : and before the curly braces, so we can stick to the convention in the rest of the file
|
|
||
| return ( | ||
| <div className="home-page"> | ||
| hello |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
For people with visual impairments or colorblindness, the text in the 'Specific portal' button was difficult to read. To accommodate all users the background color of the button was changed to a more high contrast color that's in conformance with the WCAG standards.
Screenshots or Videos (if applicable)
Include screenshots or video recordings to show off your change (if applicable).
Related Issues
Fixes Issue #309
Test Plan
Please describe the exact steps you followed to test your change. Be as clear as possible so a reviewer can follow the same steps. List what UI interactions are needed, or if there are automated tests then list what should be run. For example:
Checklist Before Requesting a Review