Skip to content
This repository was archived by the owner on Nov 4, 2025. It is now read-only.

Critical issues #310

Open
Detroit-the-Dev wants to merge 5 commits into
base: develop
Choose a base branch
from
Open

Critical issues #310

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
fcf9820
test line spacing
Jul 21, 2022
362b964
added button-border color.
Jul 21, 2022
a2bffc7
made style changes to code to conform to convention
Jul 25, 2022
1cde6f5
added spacing
Jul 26, 2022
a63cced
changed button background color
Aug 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions packages/frontend/src/components/CollectionCard/CollectionCard.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,13 +15,15 @@
justify-content: space-between;
align-items: center;
}

.created-at {
color: #5a7598;
font-size: 11px;
padding: 0px;
margin: 0px;
margin-bottom: 2px;
}

h3 {
color: #152935;
font-size: 14px;
Expand Down
4 changes: 2 additions & 2 deletions packages/frontend/src/components/Dataset/Dataset.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,8 +33,8 @@ export default function Dataset({
<p>{dataset.department}</p>
</div>

<DatasetLink className="title" dataset={dataset}>
<h2>{formattedName}</h2>
<DatasetLink className="data-link-title title" dataset={dataset}>
<h2>{formattedName}</h2>asdf
Copy link

@jpsyx jpsyx Aug 11, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget to remove the "asdf" on this line

</DatasetLink>
{dataset.permalink}
</div>
Expand Down
6 changes: 6 additions & 0 deletions packages/frontend/src/components/Dataset/Dataset.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,12 @@
.dataset {
display: grid;

.data-link-title{
color:red;
&:focus-visible{
color:aqua;
}
}
Comment on lines +4 to +9
Copy link

@jpsyx jpsyx Aug 11, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget the necessary spaces here after the : and before the curly braces, so we can stick to the convention in the rest of the file

button {
height: 24px;
width: 100%;
Expand Down
2 changes: 2 additions & 0 deletions packages/frontend/src/layout/HomePage/HomePage.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,6 +108,7 @@ export default function HomePage({ portal, initialGlobalSearchVal }) {

return (
<div className="home-page">
hello
Copy link

@jpsyx jpsyx Aug 11, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's remove this "hello"! :)

<Filters
onCollapseFilterBar={setCollapseFilterBar}
collapsed={collapseFilterBar}
Expand All @@ -130,6 +131,7 @@ export default function HomePage({ portal, initialGlobalSearchVal }) {
</div>

<Switch
className="portal-switch"
checked={globalSearch}
onChange={isOn => {
setGlobalSearch(isOn);
Expand Down
6 changes: 6 additions & 0 deletions packages/frontend/src/layout/HomePage/HomePage.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,3 +134,9 @@ $LightGrey: #b2b2b2;
box-sizing: border-box;
padding: 10px 20px;
}

.portal-switch {
&:focus-visible {
outline: 3px solid #000;
}
}