unsent_saves(): scan every review lane, not just HEAD - #94
Merged
Merged
Conversation
`git log HEAD --not --remotes` is bounded by HEAD's ancestry, so with the checkout on any branch other than the reviewer's lane their saves become invisible. The docstring claimed the opposite -- "deliberately not filtered to this branch either" -- which is what made this hard to spot. Measured today with the repo left on `main`: 0 unsent saves reported while 6 sat on `review/vijay-tylertech/08282026-121644`, and the Save page read "Nothing waiting. Everything reviewed has been sent in." That is the worst possible failure for this indicator specifically. It is the one thing a reviewer checks to confirm their work still exists, and it told them it did not -- while the six commits holding four knowledge-file edits were sitting in the repo the whole time. `--branches=review/*` rather than `--branches`: machinery branches (feature/, fix/) are not saves, and listing them would report the tool's own development as the reviewer's pending work. Verified: 6 reported from `main`, matching `git log --branches='review/*' --not --remotes` exactly, where the old form reported 0. Claude-Session: https://claude.ai/code/session_01VVNYqGza2dFdeWFX7qXnwb
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
git log HEAD --not --remotesis bounded by HEAD's ancestry, so with the checkout onany branch other than the reviewer's lane their saves become invisible. The docstring
claimed the opposite -- "deliberately not filtered to this branch either" -- which is
what made this hard to spot.
Measured today with the repo left on
main: 0 unsent saves reported while 6 sat onreview/vijay-tylertech/08282026-121644, and the Save page read "Nothing waiting.Everything reviewed has been sent in."
That is the worst possible failure for this indicator specifically. It is the one
thing a reviewer checks to confirm their work still exists, and it told them it did
not -- while the six commits holding four knowledge-file edits were sitting in the
repo the whole time.
--branches=review/*rather than--branches: machinery branches (feature/, fix/)are not saves, and listing them would report the tool's own development as the
reviewer's pending work.
Verified: 6 reported from
main, matchinggit log --branches='review/*' --not --remotesexactly, where the old form reported 0.Claude-Session: https://claude.ai/code/session_01VVNYqGza2dFdeWFX7qXnwb