Save badge: count review_scope(), the same trees the Change list shows - #95
Merged
Merged
Conversation
The badge counted `transcripts` only. With four edited knowledge files in the tree it read 5 beside a status line saying 9 -- the same "two numbers for one thing" the Blueprint half of this count had until yesterday, and visible from every page. review_scope() exists for exactly this and its docstring already says these must agree: "when the list was scoped to transcripts and the staging to both, the page showed a reviewer less than the button was about to save." nav_counts() was the one caller not asking it. Verified: badge 9, status line 9, Change list 9 across its three groups (3 Reviews, 4 Agent files, 2 Blueprint docs). Claude-Session: https://claude.ai/code/session_01VVNYqGza2dFdeWFX7qXnwb
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The badge counted
transcriptsonly. With four edited knowledge files in the tree itread 5 beside a status line saying 9 -- the same "two numbers for one thing" the
Blueprint half of this count had until yesterday, and visible from every page.
review_scope() exists for exactly this and its docstring already says these must
agree: "when the list was scoped to transcripts and the staging to both, the page
showed a reviewer less than the button was about to save." nav_counts() was the one
caller not asking it.
Verified: badge 9, status line 9, Change list 9 across its three groups (3 Reviews,
4 Agent files, 2 Blueprint docs).
Claude-Session: https://claude.ai/code/session_01VVNYqGza2dFdeWFX7qXnwb