Skip to content

Save badge: count review_scope(), the same trees the Change list shows #95

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vijay-tylertech merged 1 commit into from
Aug 30, 2026
Merged

Save badge: count review_scope(), the same trees the Change list shows #95

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion scripts/review_server.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3723,7 +3723,11 @@ def nav_counts():
if ME and (fm.get("suggested_to") == ME or fm.get("awaiting") == ME
or ME in {o for a in effective_agents(fm) for o in owners_of(a)}):
mine_n += 1
_, st = git("status", "--porcelain", "--", "transcripts")
# review_scope() EXACTLY, which is what the status line and the Change list count. This was
# scoped to `transcripts` alone, so four edited knowledge files were missing from the badge -
# the same "two numbers for one thing" the Blueprint half of this count already had. The
# docstring on review_scope() says these must agree; nav_counts was the one place not asking.
_, st = git("status", "--porcelain", "--", *review_scope())
uncommitted = len([l for l in st.splitlines() if l.strip()])
# BOTH REPOS, matching the status line and the Change list on the Save page. The badge counted
# this working tree only, so a batch with 3 transcript edits and 2 staged Blueprint files put
Expand Down
Loading