-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
Remove redundant Monad requirement when Parallel is provided #2180
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I believe this will break binary compatibility, so it probably won't be able to make it in until the eventual Cats 2.0. I'm not sure what the current branch strategy is for this sort of thing (if we have one yet).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch, thank you! :)
Is this going to be MiMa compatible though? 🤔 |
@LukaJCB see comment above :) |
Oh, duh, sorry about that! |
I wonder when we are breaking if we should do: trait Parallel[M[_]] {
type F[_]
} Since F is generally only used as an intermediate type, this could make it easier to specify the types when you need to. |
we don't have a branch strategy yet. we might have a cats 2.0 that is bin compat on scala 2.11 and 2.12. |
Why call it 2.0 if it is binary compatible? |
@johnynek, TBC it's just a possibility, we might be forced to drop scala 2.10 if we upgrade scalajs. We would want to reserver 1.x versions for 2.10 if we want to continue support 2.10 and back port features to it, which means that the main branch (with the latest scalajs and discipline (also dropping 2.10) will have to be on 2.x version numbers. |
I was also thinking about that @johnynek (RE: making |
I think this PR was still relevant. The issue noted that |
I believe this will break binary compatibility, so it probably won't
be able to make it in until the eventual Cats 2.0. I'm not sure what the
current branch strategy is for this sort of thing (if we have one yet).