GitHub Actions: Use YAML anchors #38
Conversation
Refactor e2e job to use shared matrix configuration.
There was a problem hiding this comment.
Pull request overview
This PR refactors the GitHub Actions workflow to use YAML anchors for reducing duplication in matrix configurations. The build job's matrix is now defined as an anchor (&matrix) and referenced in the e2e job using an alias (*matrix), eliminating the need to maintain duplicate matrix definitions.
Key Changes
- Defined a YAML anchor (
&matrix) on thebuildjob's matrix configuration - Replaced the
e2ejob's explicit matrix definition with a reference to the shared matrix anchor (*matrix)
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| variant: darwin_arm64 | ||
| - runs-on: macos-15-intel | ||
| variant: darwin_amd64 | ||
| matrix: *matrix |
There was a problem hiding this comment.
[nitpick] The e2e job will now inherit the spc-variant field from the anchor definition (defined in the build job at lines 56, 59, 62, 65), even though this field is not used by the e2e job. While this won't cause functional issues, it introduces unnecessary matrix configuration that could confuse future maintainers.
Consider one of these approaches:
- Keep the matrices separate to maintain clarity about which fields each job uses
- Split the anchor into a base configuration that both jobs extend with their specific fields (though GitHub Actions YAML doesn't support merge keys with anchors)
- Accept the extra field as a minor trade-off for reduced duplication and add a comment explaining that not all matrix fields are used by all jobs
| matrix: *matrix | |
| matrix: | |
| include: | |
| - runs-on: ubuntu-24.04-arm | |
| variant: linux_arm64 | |
| - runs-on: ubuntu-24.04 | |
| variant: linux_amd64 | |
| - runs-on: macos-15 | |
| variant: darwin_arm64 | |
| - runs-on: macos-15-intel | |
| variant: darwin_amd64 |
No description provided.