Skip to content

GitHub Actions: Use YAML anchors #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tangrufus merged 1 commit into from
Dec 7, 2025
Merged

GitHub Actions: Use YAML anchors #38

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 2 additions & 11 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ jobs:
name: build (${{ matrix.runs-on }})
needs: phar
strategy:
matrix:
matrix: &matrix
include:
- runs-on: ubuntu-24.04-arm
variant: linux_arm64
Expand Down Expand Up @@ -119,16 +119,7 @@ jobs:
name: e2e (${{ matrix.runs-on }})
needs: build
strategy:
matrix:
include:
- runs-on: ubuntu-24.04-arm
variant: linux_arm64
- runs-on: ubuntu-24.04
variant: linux_amd64
- runs-on: macos-15
variant: darwin_arm64
- runs-on: macos-15-intel
variant: darwin_amd64
matrix: *matrix
Copy link

Copilot AI Dec 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] The e2e job will now inherit the spc-variant field from the anchor definition (defined in the build job at lines 56, 59, 62, 65), even though this field is not used by the e2e job. While this won't cause functional issues, it introduces unnecessary matrix configuration that could confuse future maintainers.

Consider one of these approaches:

  1. Keep the matrices separate to maintain clarity about which fields each job uses
  2. Split the anchor into a base configuration that both jobs extend with their specific fields (though GitHub Actions YAML doesn't support merge keys with anchors)
  3. Accept the extra field as a minor trade-off for reduced duplication and add a comment explaining that not all matrix fields are used by all jobs
Suggested change
matrix: *matrix
matrix:
include:
- runs-on: ubuntu-24.04-arm
variant: linux_arm64
- runs-on: ubuntu-24.04
variant: linux_amd64
- runs-on: macos-15
variant: darwin_arm64
- runs-on: macos-15-intel
variant: darwin_amd64

Copilot uses AI. Check for mistakes.
runs-on: ${{ matrix.runs-on }}
env:
GOFLAGS: '-mod=mod'
Expand Down
Loading