Skip to content

Fixed typo #2022

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fixed typo #2022

wants to merge 2 commits into from

Conversation

ez-me
Copy link

@ez-me ez-me commented Apr 18, 2025

Description

Some words in documents referenced chrome or cromite when in reality they were meant to refer to cromite and bromite, respectively.

All submissions

  • there are no other open Pull Requests for the same update/change
  • Bromite can be built with these changes
  • I have tested that the new change works as intended (AVD or physical device will do)

Format

  • patch subject and filename match (e.g. Subject: Alternative cache (NIK-based) -> Alternative-cache-NIK-based.patch)
  • patch description contains explanation of changes
  • no unnecessary whitespace or unrelated changes

@ez-me
Copy link
Author

ez-me commented Apr 18, 2025

I know this isn't a code change and I'm okay if you do this yourself and not add me to the contributors list.

ghost

This comment was marked as duplicate.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure this can be changed? In Chromium-based browsers, you often have to use the term "Chrome" or "Chromium," even if the browser itself has a different name.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Later in the readme it's stated:

Now, run sudo apparmor_parser -r /etc/apparmor.d/cromite to apply the changes.

And I get what you are saying, as it's for the name of the binary (chrome in the example), but I use Arch's AUR package and there the binary name is indeed cromite, so maybe the second mention of the file should need changing, or the entire section should have a "your cromite binary may have a different name (chrome, chromium, cromite), make sure to use that one" or similar.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cromite. With a capital letter in the beginning.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cromite's predecessor was Cromite?

I changed it to bromite because that's what made sense to me

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I meant "Bromite". But Bromite with a capital letter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant