-
Notifications
You must be signed in to change notification settings - Fork 113
Fixed typo #2022
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Fixed typo #2022
Conversation
I know this isn't a code change and I'm okay if you do this yourself and not add me to the contributors list. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are you sure this can be changed? In Chromium-based browsers, you often have to use the term "Chrome" or "Chromium," even if the browser itself has a different name.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Later in the readme it's stated:
Now, run sudo apparmor_parser -r /etc/apparmor.d/cromite
to apply the changes.
And I get what you are saying, as it's for the name of the binary (chrome in the example), but I use Arch's AUR package and there the binary name is indeed cromite, so maybe the second mention of the file should need changing, or the entire section should have a "your cromite binary may have a different name (chrome, chromium, cromite), make sure to use that one" or similar.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cromite. With a capital letter in the beginning.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cromite's predecessor was Cromite?
I changed it to bromite because that's what made sense to me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I meant "Bromite". But Bromite with a capital letter.
Description
Some words in documents referenced chrome or cromite when in reality they were meant to refer to cromite and bromite, respectively.
All submissions
Format
Subject: Alternative cache (NIK-based)
->Alternative-cache-NIK-based.patch
)