Skip to content

Fixed typo #2022

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
+2 −2
Open

Fixed typo #2022

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7b8874b
fixed typo
ez-me Apr 18, 2025
8be0b74
Typo fix
ez-me Apr 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure this can be changed? In Chromium-based browsers, you often have to use the term "Chrome" or "Chromium," even if the browser itself has a different name.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Later in the readme it's stated:

Now, run sudo apparmor_parser -r /etc/apparmor.d/cromite to apply the changes.

And I get what you are saying, as it's for the name of the binary (chrome in the example), but I use Arch's AUR package and there the binary name is indeed cromite, so maybe the second mention of the file should need changing, or the entire section should have a "your cromite binary may have a different name (chrome, chromium, cromite), make sure to use that one" or similar.

Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,7 @@ working in progress in https://github.com/uazo/cromite/issues/771
This happens because, starting with Ubuntu 24.04, Apparmor
restricts the use of unprivileged user namespaces. To fix this, you have several options:
#### 1. Creating an apparmor profile for cromite
Create `/etc/apparmor.d/chrome`, and write:
Create `/etc/apparmor.d/cromite`, and write:
```
abi <abi/4.0>,
include <tunables/global>
Expand Down
2 changes: 1 addition & 1 deletion docs/FAQ.md
View file
Open in desktop
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cromite. With a capital letter in the beginning.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cromite's predecessor was Cromite?

I changed it to bromite because that's what made sense to me

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I meant "Bromite". But Bromite with a capital letter.

Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ JIT stands for Just-In-Time compilation and is a feature of chromium v8 which is

However, the use of JIT opens up possible security holes exploited over time to scale the chromium sandbox and allow access to privileged processes by javascript. Technically, the reason is that the memory used by JIT is read/write/execute and can therefore be exploited to insert code from, for example, a UAF (use-after-free) error within a javascript callback. In addition, the activation of JIT allows the exchange of shared memory between different frames, an amazing and at the same time risky feature.

For this reason, in cromite (and its predecessor cromite) it was chosen to disable JIT by default, penalising execution but offering a smaller attack surface.
For this reason, in cromite (and its predecessor bromite) it was chosen to disable JIT by default, penalising execution but offering a smaller attack surface.

If you trust the site or have performance needs or need to use WebAssembly, you can activate that feature specifically for that website via UI:
<details>
Expand Down