Fix missing parentheses in toString method call#129
Merged
albertyw merged 1 commit intouber:masterfrom Jan 28, 2026
Merged
Conversation
The error message for invalid operator type was displaying the toString
function reference instead of the actual valid operator types. This was
caused by missing parentheses on the toString method call.
Before: 'Operator must be one of [function toString() { [native code] }]'
After: 'Operator must be one of [and,or]'
albertyw
approved these changes
Jan 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Problem
In
src/alert/condition.ts, thewithOperatormethod was usingtypes.toString(function reference) instead oftypes.toString()(function call) when constructing the error message. This resulted in unhelpful error messages:Before:
After:
Changes
toStringmethod call on line 65 ofsrc/alert/condition.tsTesting