Fix missing parentheses in toString method call in withOperator#130
Closed
Nepomuk5665 wants to merge 1 commit intouber:masterfrom
Closed
Fix missing parentheses in toString method call in withOperator#130Nepomuk5665 wants to merge 1 commit intouber:masterfrom
Nepomuk5665 wants to merge 1 commit intouber:masterfrom
Conversation
albertyw
approved these changes
Jan 28, 2026
Member
|
Duplicate of #129 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix a bug in
Condition.withOperator()wheretypes.toStringwas used instead oftypes.toString(), causing the error message to display[Function: toString]instead of the actual valid operatorsand,or.Problem
When an invalid operator is passed to
withOperator(), the error message shows:Instead of the intended:
Fix
Add the missing parentheses to properly call the
toString()method on the array.This is the same type of bug that was fixed in commit 52c27bd for
withEvaluator.